letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Notification Decoration Revised (#5312)

Browse Source 
1. I removed the grey dots for when there is activity in rooms set to mentions or mute.
2. For all unread rooms, I made the message preview text bold for better legibility
3. For rooms with no unreads, I made the font weight regular, again for legibility

We have also mergeg the new room list activity rendering with the existing feature hide unread badge feature flag and provide 3 variations: current production behavior, no badge but bolding, and no bolding and no badge
This commit is contained in:
amshak
2026-04-21 12:12:07 +01:00
committed by GitHub
parent e51e93c3f1
commit b16bbdcc72
36 changed files with 141 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
UnitTests/Sources/HomeScreenRoomTests.swift
View File

@@ -55,7 +55,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(!room.isHighlighted)
#expect(!room.badges.isDotShown)
@@ -73,7 +73,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: true)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -83,7 +83,7 @@ struct HomeScreenRoomTests {
}
@Test
mutating func voiceCallBadget() {
mutating func voiceCallBadge() {
setupRoomSummary(isMarkedUnread: true,
unreadMessagesCount: 0,
unreadMentionsCount: 0,
@@ -92,7 +92,7 @@ struct HomeScreenRoomTests {
hasOngoingCall: true,
activeCallIntent: .audio)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.badges.callBadgeType == .voice)
}
@@ -106,7 +106,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(!room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -124,7 +124,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -142,7 +142,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -160,7 +160,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: true)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(!room.isHighlighted)
#expect(!room.badges.isDotShown)
@@ -178,7 +178,7 @@ struct HomeScreenRoomTests {
notificationMode: .mentionsAndKeywordsOnly,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(!room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -196,7 +196,7 @@ struct HomeScreenRoomTests {
notificationMode: .mentionsAndKeywordsOnly,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: true)
let room = HomeScreenRoom(summary: roomSummary, roomListActivityVisibility: .show)
#expect(!room.isHighlighted)
#expect(!room.badges.isDotShown)
@@ -216,7 +216,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -234,7 +234,7 @@ struct HomeScreenRoomTests {
notificationMode: .allMessages,
hasOngoingCall: false)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)
@@ -252,7 +252,7 @@ struct HomeScreenRoomTests {
notificationMode: .mute,
hasOngoingCall: true)
let room = HomeScreenRoom(summary: roomSummary, hideUnreadMessagesBadge: false)
let room = HomeScreenRoom(summary: roomSummary)
#expect(room.isHighlighted)
#expect(room.badges.isDotShown)