From 7cb46186c4c4fdf28eeb549d18fc63284a19f9ec Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Mon, 28 Nov 2022 17:11:03 +0200 Subject: [PATCH] Remove unused settings appearance section and txid handling warnings --- .../Settings/View/SettingsScreen.swift | 29 ------------------- .../MessageTimelineItem.swift | 1 - .../Services/Timeline/TimelineItemProxy.swift | 1 - 3 files changed, 31 deletions(-) diff --git a/ElementX/Sources/Screens/Settings/View/SettingsScreen.swift b/ElementX/Sources/Screens/Settings/View/SettingsScreen.swift index 37fd1b55c..34033fc83 100644 --- a/ElementX/Sources/Screens/Settings/View/SettingsScreen.swift +++ b/ElementX/Sources/Screens/Settings/View/SettingsScreen.swift @@ -32,9 +32,6 @@ struct SettingsScreen: View { userSection .listRowBackground(rowBackgroundColor) - appearanceSection - .listRowBackground(rowBackgroundColor) - analyticsSection .listRowBackground(rowBackgroundColor) @@ -84,28 +81,6 @@ struct SettingsScreen: View { } } - private var appearanceSection: some View { - Section { - Button(action: appearance) { - HStack { - Image(systemName: "paintpalette") - .foregroundColor(.element.systemGray) - .padding(4) - .background(Color.element.systemGray6) - .clipShape(Circle()) - .frame(width: menuIconSize, height: menuIconSize) - Text(ElementL10n.settingsAppearance) - Spacer() - Image(systemName: "chevron.forward") - .foregroundColor(.element.tertiaryContent) - } - } - .listRowInsets(listRowInsets) - .foregroundColor(.element.primaryContent) - .accessibilityIdentifier("appearanceButton") - } - } - @ViewBuilder private var userAvatar: some View { if let avatar = context.viewState.userAvatar { @@ -205,10 +180,6 @@ struct SettingsScreen: View { .accessibilityIdentifier("closeButton") } - private func appearance() { - #warning("Not implemented") - } - private func close() { context.send(viewAction: .close) } diff --git a/ElementX/Sources/Services/Timeline/TimeLineItemContent/MessageTimelineItem.swift b/ElementX/Sources/Services/Timeline/TimeLineItemContent/MessageTimelineItem.swift index 45ae09551..1f8385045 100644 --- a/ElementX/Sources/Services/Timeline/TimeLineItemContent/MessageTimelineItem.swift +++ b/ElementX/Sources/Services/Timeline/TimeLineItemContent/MessageTimelineItem.swift @@ -36,7 +36,6 @@ struct MessageTimelineItem { let content: Content var id: String { - #warning("Handle txid properly") switch item.key() { case .transactionId(let txnID): return txnID diff --git a/ElementX/Sources/Services/Timeline/TimelineItemProxy.swift b/ElementX/Sources/Services/Timeline/TimelineItemProxy.swift index e594d2825..508e7f689 100644 --- a/ElementX/Sources/Services/Timeline/TimelineItemProxy.swift +++ b/ElementX/Sources/Services/Timeline/TimelineItemProxy.swift @@ -51,7 +51,6 @@ struct EventTimelineItemProxy: CustomDebugStringConvertible { } var id: String { - #warning("Handle txid in a better way") switch item.key() { case .transactionId(let txnID): return txnID