From 74f5ab18e93b6da65d78e6915cac9060a810e2e6 Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Fri, 6 Feb 2026 13:10:59 +0200 Subject: [PATCH] Fix a retain cycle in the `SecureBackupController` `remoteBackupStateTask` Try to prevent closure crashes we've been seeing in sentry --- .../Services/SecureBackup/SecureBackupController.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ElementX/Sources/Services/SecureBackup/SecureBackupController.swift b/ElementX/Sources/Services/SecureBackup/SecureBackupController.swift index 441bc299f..7b5cb1757 100644 --- a/ElementX/Sources/Services/SecureBackup/SecureBackupController.swift +++ b/ElementX/Sources/Services/SecureBackup/SecureBackupController.swift @@ -189,7 +189,9 @@ class SecureBackupController: SecureBackupControllerProtocol { // MARK: - Private private func updateBackupStateFromRemote(retry: Bool = true) { - remoteBackupStateTask = Task { + remoteBackupStateTask = Task { [weak self] in + guard let self else { return } + do { MXLog.info("Checking if backup exists on the server") let backupExists = try await self.encryption.backupExistsOnServer()