Various CI fixes (#161)

* Update homebrew dependencies like on the other workflows. Fixes problems caused by buggy swiftformat prebundled on the github actions macos runner

* Removed UI tests from PR tests and running them on a schedule instead. Hopefuly fixed code coverage.

* Added back simulator versions as they need to match UI test snapshots

* Allow UI tests to run on this PR

* Added back skipped UI tests

* Fix danger sometimes not working on forks and disable integration tests on them

.github/workflows/danger.yml

@@ -4,10 +4,9 @@ on: [pull_request]
 
 jobs:
   build:
-    # Don't run for forks as secrets are unavailable.
-    if: github.event.pull_request.head.repo.full_name == github.repository
-    runs-on: ubuntu-latest
     name: Danger
+    runs-on: ubuntu-latest
+
     steps:
       - uses: actions/checkout@v3
 

.github/workflows/integration-tests.yml

@@ -2,12 +2,14 @@ name: Integration tests
 
 on:
   schedule:
-    - cron:  '0 3 * * 1-5'
+    - cron:  '0 2 * * 1-5'
     
   workflow_dispatch:
 
 jobs:
   integration_tests:
+    if: github.event.pull_request.head.repo.full_name == github.repository
+
     name: Integration Tests
     runs-on: macos-12
 
@@ -19,6 +21,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Brew bundle
+        run:
+          brew update && brew bundle && brew upgrade
+
       - uses: actions/cache@v3
         with:
           path: vendor/bundle

.github/workflows/ui_tests.yml

@@ -1,8 +1,11 @@
-name: Tests
+name: UI Tests
 
 on:
-  push:
-    branches: [ develop ]
+  workflow_dispatch:
+  
+  schedule:
+    - cron:  '0 0 * * 1-5'
+
   pull_request:
 
 jobs:
@@ -13,7 +16,7 @@ jobs:
     concurrency:
       # When running on develop, use the sha to allow all runs of this workflow to run concurrently.
       # Otherwise only allow a single run of this workflow on each branch, automatically cancelling older runs.
-      group: ${{ github.ref == 'refs/heads/develop' && format('tests-develop-{0}', github.sha) || format('tests-{0}', github.ref) }}
+      group: ${{ github.ref == 'refs/heads/develop' && format('ui-tests-develop-{0}', github.sha) || format('ui-tests-{0}', github.ref) }}
       cancel-in-progress: true
 
     steps:
@@ -26,6 +29,10 @@ jobs:
         with:
           lfs: true
 
+      - name: Brew bundle
+        run:
+          brew update && brew bundle && brew upgrade
+
       - uses: actions/cache@v3
         with:
           path: vendor/bundle
@@ -33,17 +40,13 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gems-
 
-      - name: Brew bundle
-        run:
-          brew update && brew bundle && brew upgrade
-
       - name: Bundle install
         run: |
           bundle config path vendor/bundle
           bundle install --jobs 4 --retry 3
       
       - name: Run tests
-        run: bundle exec fastlane tests
+        run: bundle exec fastlane ui_tests
       
       - name: Archive artifacts
         uses: actions/upload-artifact@v3

.github/workflows/unit_tests.yml

@@ -0,0 +1,45 @@
+name: Unit Tests
+
+on:
+  workflow_dispatch:
+  
+  push:
+    branches: [ develop ]
+  
+  pull_request:
+
+jobs:
+  tests:
+    name: Tests
+    runs-on: macos-12
+
+    concurrency:
+      # When running on develop, use the sha to allow all runs of this workflow to run concurrently.
+      # Otherwise only allow a single run of this workflow on each branch, automatically cancelling older runs.
+      group: ${{ github.ref == 'refs/heads/develop' && format('unit-tests-develop-{0}', github.sha) || format('unit-tests-{0}', github.ref) }}
+      cancel-in-progress: true
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Brew bundle
+        run:
+          brew update && brew bundle && brew upgrade
+
+      - uses: actions/cache@v3
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+
+      - name: Bundle install
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      
+      - name: Run tests
+        run: bundle exec fastlane unit_tests
+      
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3