letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Permissions screen redesign (#4735)

Browse Source 
* Redesigned permissions screen

# Conflicts:
#	ElementX.xcodeproj/project.pbxproj

* updated tests

* update proj

* fix pseudo language tests
This commit is contained in:
Mauro
2025-11-12 14:41:44 +01:00
committed by GitHub
parent c75353a903
commit 6d57153136
76 changed files with 545 additions and 467 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
UnitTests/Sources/RoomChangePermissionsScreenViewModelTests.swift
View File

@@ -22,7 +22,6 @@ class RoomChangePermissionsScreenViewModelTests: XCTestCase {
override func setUp() {
roomProxy = JoinedRoomProxyMock(.init())
viewModel = RoomChangePermissionsScreenViewModel(currentPermissions: .init(powerLevels: .mock),
group: .roomDetails,
roomProxy: roomProxy,
userIndicatorController: UserIndicatorControllerMock(),
analytics: ServiceLocator.shared.analytics)
@@ -30,30 +29,30 @@ class RoomChangePermissionsScreenViewModelTests: XCTestCase {
func testChangeSetting() {
// Given a screen with no changes.
guard let index = context.settings.firstIndex(where: { $0.keyPath == \.roomAvatar }) else {
guard let index = context.settings[.roomDetails]?.firstIndex(where: { $0.keyPath == \.roomAvatar }) else {
XCTFail("There should be a setting for the room avatar.")
return
}
XCTAssertEqual(context.settings[index].value, .moderator)
XCTAssertEqual(context.settings[.roomDetails]?[index].value, .moderator)
XCTAssertFalse(context.viewState.hasChanges)
// When updating a setting.
let setting = RoomPermissionsSetting(title: "", value: .user, keyPath: \.roomAvatar)
context.settings[index] = setting
context.settings[.roomDetails]?[index] = setting
// Then the setting should update and the changes should be flagged.
XCTAssertEqual(context.settings[index].value, .user)
XCTAssertEqual(context.settings[.roomDetails]?[index].value, .user)
XCTAssertTrue(context.viewState.hasChanges)
}
func testSave() async throws {
// Given a screen with changes.
guard let index = context.settings.firstIndex(where: { $0.keyPath == \.roomAvatar }) else {
guard let index = context.settings[.roomDetails]?.firstIndex(where: { $0.keyPath == \.roomAvatar }) else {
XCTFail("There should be a setting for the room avatar.")
return
}
context.settings[index] = RoomPermissionsSetting(title: "", value: .user, keyPath: \.roomAvatar)
XCTAssertEqual(context.settings[index].value, .user)
context.settings[.roomDetails]?[index] = RoomPermissionsSetting(title: "", value: .user, keyPath: \.roomAvatar)
XCTAssertEqual(context.settings[.roomDetails]?[index].value, .user)
XCTAssertTrue(context.viewState.hasChanges)
XCTAssertEqual(context.settings.count, 3)