letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Space Settings: Leave Room (#4700)

Browse Source 
* Implementation for all navigations inside the space settings aside the left space action

# Conflicts:
#	ElementX/Sources/FlowCoordinators/SpaceSettingsFlowCoordinator.swift

* refactored the leave space view to use its own view model

# Conflicts:
#	ElementX.xcodeproj/project.pbxproj

* implemented the leave space view model also in the settings screen, and corrected some tests

* reusing the details coordinator for the space settings screen

* leave space from settings implemented

* fix project

* minor pr fixes

* code improvements
This commit is contained in:
Mauro
2025-11-07 12:11:21 +01:00
committed by GitHub
parent 5897c8f3fe
commit 6b19d109c7
22 changed files with 407 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
UnitTests/Sources/SpaceScreenViewModelTests.swift
View File

@@ -178,29 +178,30 @@ class SpaceScreenViewModelTests: XCTestCase {
func testLeavingSpace() async throws {
setupViewModel()
XCTAssertNil(context.leaveHandle)
XCTAssertNil(context.leaveSpaceViewModel)
let deferredHandle = deferFulfillment(context.observe(\.leaveHandle)) { $0 != nil }
let deferredHandle = deferFulfillment(context.observe(\.leaveSpaceViewModel)) { $0 != nil }
context.send(viewAction: .leaveSpace)
try await deferredHandle.fulfill()
XCTAssertNotNil(context.leaveHandle, "The leave action should show the leave view.")
XCTAssertNotNil(context.leaveSpaceViewModel, "The leave action should show the leave view.")
let handle = try XCTUnwrap(context.leaveHandle)
let leaveSpaceViewModel = try XCTUnwrap(context.leaveSpaceViewModel)
let handle = try XCTUnwrap(context.leaveSpaceViewModel?.state.leaveHandle)
let selectedCount = handle.selectedCount
let firstSelectedRoom = try XCTUnwrap(handle.rooms.first { $0.isSelected })
XCTAssertGreaterThan(selectedCount, 0, "The leave view should have selected rooms to begin with")
context.send(viewAction: .deselectAllLeaveRoomDetails)
leaveSpaceViewModel.context.send(viewAction: .deselectAll)
XCTAssertEqual(handle.selectedCount, 0, "Deselecting all should result in no selected rooms.")
context.send(viewAction: .toggleLeaveSpaceRoomDetails(id: firstSelectedRoom.spaceRoomProxy.id))
leaveSpaceViewModel.context.send(viewAction: .toggleRoom(roomID: firstSelectedRoom.spaceRoomProxy.id))
XCTAssertEqual(handle.selectedCount, 1, "Toggling a room should result in 1 selected room")
// Confirming the leave should leave the selected room and then the space.
let deferredAction = deferFulfillment(viewModel.actionsPublisher) { $0.isLeftSpace }
context.send(viewAction: .confirmLeaveSpace)
leaveSpaceViewModel.context.send(viewAction: .confirmLeaveSpace)
try await deferredAction.fulfill()
XCTAssertNil(context.leaveHandle)
XCTAssertNil(context.leaveSpaceViewModel)
XCTAssertTrue(rustLeaveHandle.leaveRoomIdsCalled)
XCTAssertEqual(rustLeaveHandle.leaveRoomIdsReceivedRoomIds,
[firstSelectedRoom.spaceRoomProxy.id, spaceRoomListProxy.id],