Various UI test fixes (#370)

* Increase integration tests time limits again as they're still ocasionally failing

* Fixed NavigationRootCoordinator name in logs

* Refactor UI tests hierarchy and introduce new userFlowScreen

* Introduce a RoomTimelineControllerFactory so that it can be mocked in the UserFlow UI tests

* Start using a mock timeline controller for the UserSession flows

* Remove the WeakDictionary dependency and replce it with a plain NSMapTable in the BackgroundTaskService

* Allow multiple UITests screenshots per screen

* Prevent the view hierarchy changing when taking screenshots

* Add UserSessionScreen UI tests

* Fix label triaging workflow project identifier as per vector-im/element-ios/pull/7150

* Fix settings screen tests

* Fix roomPlainNoAvatar and roomEncryptedWithAvatar UI tests

* Fix modal server selection screen UI tests

* Fix bug report and login screen UI tests

* Fix text typing missing characters on UI tests

* Fix sliding sync configuration on integration tests

* Stop crashing if not finding a particular room through the MockClientProxy

IntegrationTests/Sources/ApplicationTests.swift

@@ -31,7 +31,7 @@ class ApplicationTests: XCTestCase {
             return
         }
         
-        let expectedDuration = 4.0
+        let expectedDuration = 5.0
         XCTAssertLessThanOrEqual(actualDuration, expectedDuration)
     }
 }

IntegrationTests/Sources/LoginTests.swift

@@ -17,7 +17,7 @@
 import XCTest
 
 class LoginTests: XCTestCase {
-    let expectedDuration = 30.0
+    let expectedDuration = 32.0
     
     func testLoginFlow() throws {
         let parser = TestMeasurementParser()
@@ -52,6 +52,11 @@ class LoginTests: XCTestCase {
         
         homeserverTextField.clearAndTypeText(app.homeserver)
         
+        let slidingSyncTextField = app.textFields["slidingSyncProxyAddressTextField"]
+        XCTAssertTrue(slidingSyncTextField.waitForExistence(timeout: 5.0))
+        
+        slidingSyncTextField.clearAndTypeText(app.homeserver)
+        
         let confirmButton = app.buttons["confirmButton"]
         XCTAssertTrue(confirmButton.exists)
         confirmButton.tap()
@@ -59,14 +64,12 @@ class LoginTests: XCTestCase {
         let usernameTextField = app.textFields["usernameTextField"]
         XCTAssertTrue(usernameTextField.exists)
         
-        usernameTextField.tap()
-        usernameTextField.typeText(app.username)
+        usernameTextField.clearAndTypeText(app.username)
         
         let passwordTextField = app.secureTextFields["passwordTextField"]
         XCTAssertTrue(passwordTextField.exists)
         
-        passwordTextField.tap()
-        passwordTextField.typeText(app.password)
+        passwordTextField.clearAndTypeText(app.password)
         
         let nextButton = app.buttons["nextButton"]
         XCTAssertTrue(nextButton.exists)

IntegrationTests/Sources/XCUIElement.swift

@@ -1,33 +0,0 @@
-//
-// Copyright 2022 New Vector Ltd
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
-import XCTest
-
-extension XCUIElement {
-    func clearAndTypeText(_ text: String) {
-        guard let stringValue = value as? String else {
-            XCTFail("Tried to clear and type text into a non string value")
-            return
-        }
-
-        tap()
-
-        let deleteString = String(repeating: XCUIKeyboardKey.delete.rawValue, count: stringValue.count)
-
-        typeText(deleteString)
-        typeText(text)
-    }
-}

IntegrationTests/SupportingFiles/target.yml

@@ -57,3 +57,4 @@ targets:
     sources:
     - path: ../Sources
     - path: ../SupportingFiles
+    - path: ../../ElementX/Sources/Other/Extensions/XCUIElement.swift