Edit poll UX (#2151)

* Add edit poll on room proxy

* Add CreatePollMode

* Add “edit poll” presentation flow

* Add delete poll section

* Inject editing poll

* Add submit action

* Refactor validation logic

* Add edit/delete actions

* Fix bubble timestamp for polls

* Update localisations

* Refactor CreatePoll -> PollForm

* Refactor tests

* Update rust sdk to 0.0.5-november23

* Update confirmation alerts

* Add edit support in TimelineItem menu

* Refactor a11y id

* Cleanup

* Fix failing tests

* Add tests

* Refine isEditable workaround

* Refactor timestamp in TimelineItemBubbledStylerView

UnitTests/Sources/PollFormScreenViewModelTests.swift

@@ -0,0 +1,158 @@
+//
+// Copyright 2022 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import XCTest
+
+@testable import ElementX
+
+@MainActor
+class PollFormScreenViewModelTests: XCTestCase {
+    var viewModel: PollFormScreenViewModelProtocol!
+    
+    var context: PollFormScreenViewModelType.Context {
+        viewModel.context
+    }
+    
+    override func setUpWithError() throws {
+        viewModel = PollFormScreenViewModel(mode: .new)
+    }
+
+    func testNewPollInitialState() async throws {
+        XCTAssertEqual(context.options.count, 2)
+        XCTAssertTrue(context.options.allSatisfy(\.text.isEmpty))
+        XCTAssertTrue(context.question.isEmpty)
+        XCTAssertTrue(context.viewState.isSubmitButtonDisabled)
+        XCTAssertFalse(context.viewState.bindings.isUndisclosed)
+        
+        // Cancellation should work without confirmation
+        let deferred = deferFulfillment(viewModel.actions, until: { _ in true })
+        context.send(viewAction: .cancel)
+        let action = try await deferred.fulfill()
+        XCTAssertNil(context.alertInfo)
+        XCTAssertEqual(action, .cancel)
+    }
+    
+    func testEditPollInitialState() async throws {
+        setupViewModel(mode: .edit(eventID: "foo", poll: .emptyDisclosed))
+        XCTAssertEqual(context.options.count, 3)
+        XCTAssertTrue(context.options.allSatisfy { !$0.text.isEmpty })
+        XCTAssertFalse(context.question.isEmpty)
+        XCTAssertTrue(context.viewState.isSubmitButtonDisabled)
+        XCTAssertFalse(context.viewState.bindings.isUndisclosed)
+        
+        // Cancellation should work without confirmation
+        let deferred = deferFulfillment(viewModel.actions, until: { _ in true })
+        context.send(viewAction: .cancel)
+        let action = try await deferred.fulfill()
+        XCTAssertNil(context.alertInfo)
+        XCTAssertEqual(action, .cancel)
+    }
+    
+    func testNewPollInvalidEmptyOption() {
+        context.question = "foo"
+        context.options[0].text = "bla"
+        context.options[1].text = "bla"
+        context.send(viewAction: .addOption)
+        XCTAssertTrue(context.viewState.isSubmitButtonDisabled)
+    }
+    
+    func testEditPollInvalidEmptyOption() {
+        setupViewModel(mode: .edit(eventID: "foo", poll: .emptyDisclosed))
+        context.send(viewAction: .addOption)
+        XCTAssertTrue(context.viewState.isSubmitButtonDisabled)
+        
+        // Cancellation requires a confirmation
+        context.send(viewAction: .cancel)
+        XCTAssertNotNil(context.alertInfo)
+    }
+    
+    func testEditPollSubmitButtonState() {
+        setupViewModel(mode: .edit(eventID: "foo", poll: .emptyDisclosed))
+        XCTAssertTrue(context.viewState.isSubmitButtonDisabled)
+        context.options[0].text = "foo"
+        XCTAssertFalse(context.viewState.isSubmitButtonDisabled)
+        
+        // Cancellation requires a confirmation
+        context.send(viewAction: .cancel)
+        XCTAssertNotNil(context.alertInfo)
+    }
+
+    func testNewPollSubmit() async throws {
+        context.question = "foo"
+        context.options[0].text = "bla1"
+        context.options[1].text = "bla2"
+        XCTAssertFalse(context.viewState.isSubmitButtonDisabled)
+
+        let deferred = deferFulfillment(viewModel.actions) { action in
+            switch action {
+            case .submit:
+                return true
+            default:
+                return false
+            }
+        }
+        
+        context.send(viewAction: .submit)
+        
+        let action = try await deferred.fulfill()
+
+        guard case .submit(let question, let options, let kind) = action else {
+            XCTFail("Unexpected action")
+            return
+        }
+        XCTAssertEqual(question, "foo")
+        XCTAssertEqual(options.count, 2)
+        XCTAssertEqual(options[0], "bla1")
+        XCTAssertEqual(options[1], "bla2")
+        XCTAssertEqual(kind, .disclosed)
+    }
+
+    func testEditPollSubmit() async throws {
+        setupViewModel(mode: .edit(eventID: "foo", poll: .emptyDisclosed))
+        context.question = "What is your favorite country?"
+        context.options.append(.init(text: "France 🇫🇷"))
+        XCTAssertFalse(context.viewState.isSubmitButtonDisabled)
+
+        let deferred = deferFulfillment(viewModel.actions) { action in
+            switch action {
+            case .submit:
+                return true
+            default:
+                return false
+            }
+        }
+        
+        context.send(viewAction: .submit)
+        
+        let action = try await deferred.fulfill()
+
+        guard case .submit(let question, let options, let kind) = action else {
+            XCTFail("Unexpected action")
+            return
+        }
+        XCTAssertEqual(question, "What is your favorite country?")
+        XCTAssertEqual(options.count, 4)
+        XCTAssertEqual(options[0], "Italy 🇮🇹")
+        XCTAssertEqual(options[1], "China 🇨🇳")
+        XCTAssertEqual(options[2], "USA 🇺🇸")
+        XCTAssertEqual(options[3], "France 🇫🇷")
+        XCTAssertEqual(kind, .disclosed)
+    }
+    
+    private func setupViewModel(mode: PollFormMode) {
+        viewModel = PollFormScreenViewModel(mode: mode)
+    }
+}