letro/letro-ios
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 2 Wiki Activity

Swift Testing for Unit Tests PART 1 (#5119)

Browse Source 
* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
2026-02-19 16:20:47 +01:00
committed by GitHub
parent c92e847ed7
commit 173b39a07f
118 changed files with 4630 additions and 4129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
UnitTests/Sources/ReportContentScreenViewModelTests.swift
View File

@@ -7,15 +7,17 @@
//
@testable import ElementX
import XCTest
import Testing
@MainActor
class ReportContentScreenViewModelTests: XCTestCase {
@Suite
struct ReportContentScreenViewModelTests {
let eventID = "test-id"
let senderID = "@meany:server.com"
let reportReason = "I don't like it."
func testReportContent() async throws {
@Test
func reportContent() async throws {
// Given the report content view for some content.
let roomProxy = JoinedRoomProxyMock(.init(name: "test"))
roomProxy.reportContentReasonReturnValue = .success(())
@@ -37,14 +39,15 @@ class ReportContentScreenViewModelTests: XCTestCase {
try await deferred.fulfill()
// Then the content should be reported, but the user should not be included.
XCTAssertEqual(roomProxy.reportContentReasonCallsCount, 1, "The content should always be reported.")
XCTAssertEqual(roomProxy.reportContentReasonReceivedArguments?.eventID, eventID, "The event ID should match the content being reported.")
XCTAssertEqual(roomProxy.reportContentReasonReceivedArguments?.reason, reportReason, "The reason should match the user input.")
XCTAssertEqual(clientProxy.ignoreUserCallsCount, 0, "A call to ignore a user should not have been made.")
XCTAssertNil(clientProxy.ignoreUserReceivedUserID, "The sender shouldn't have been ignored.")
#expect(roomProxy.reportContentReasonCallsCount == 1, "The content should always be reported.")
#expect(roomProxy.reportContentReasonReceivedArguments?.eventID == eventID, "The event ID should match the content being reported.")
#expect(roomProxy.reportContentReasonReceivedArguments?.reason == reportReason, "The reason should match the user input.")
#expect(clientProxy.ignoreUserCallsCount == 0, "A call to ignore a user should not have been made.")
#expect(clientProxy.ignoreUserReceivedUserID == nil, "The sender shouldn't have been ignored.")
}
func testReportIgnoringSender() async throws {
@Test
func reportIgnoringSender() async throws {
// Given the report content view for some content.
let roomProxy = JoinedRoomProxyMock(.init(name: "test"))
roomProxy.reportContentReasonReturnValue = .success(())
@@ -67,10 +70,10 @@ class ReportContentScreenViewModelTests: XCTestCase {
try await deferred.fulfill()
// Then the content should be reported, and the user should be ignored.
XCTAssertEqual(roomProxy.reportContentReasonCallsCount, 1, "The content should always be reported.")
XCTAssertEqual(roomProxy.reportContentReasonReceivedArguments?.eventID, eventID, "The event ID should match the content being reported.")
XCTAssertEqual(roomProxy.reportContentReasonReceivedArguments?.reason, reportReason, "The reason should match the user input.")
XCTAssertEqual(clientProxy.ignoreUserCallsCount, 1, "A call should have been made to ignore the sender.")
XCTAssertEqual(clientProxy.ignoreUserReceivedUserID, senderID, "The ignored user ID should match the sender.")
#expect(roomProxy.reportContentReasonCallsCount == 1, "The content should always be reported.")
#expect(roomProxy.reportContentReasonReceivedArguments?.eventID == eventID, "The event ID should match the content being reported.")
#expect(roomProxy.reportContentReasonReceivedArguments?.reason == reportReason, "The reason should match the user input.")
#expect(clientProxy.ignoreUserCallsCount == 1, "A call should have been made to ignore the sender.")
#expect(clientProxy.ignoreUserReceivedUserID == senderID, "The ignored user ID should match the sender.")
}
}