Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that

UnitTests/Sources/EditRoomAddressScreenViewModelTests.swift

@@ -76,7 +76,7 @@ class EditRoomAddressScreenViewModelTests: XCTestCase {
         
         XCTAssertNil(roomProxy.infoPublisher.value.canonicalAlias)
         XCTAssertEqual(viewModel.context.viewState.bindings.desiredAliasLocalPart, "room-name")
-
+        
         let publishingExpectation = expectation(description: "Wait for publishing")
         roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
             defer { publishingExpectation.fulfill() }
@@ -107,7 +107,7 @@ class EditRoomAddressScreenViewModelTests: XCTestCase {
                                                    userIndicatorController: UserIndicatorControllerMock())
         
         context.desiredAliasLocalPart = "room-name"
-
+        
         let publishingExpectation = expectation(description: "Wait for publishing")
         roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
             defer { publishingExpectation.fulfill() }
@@ -144,7 +144,7 @@ class EditRoomAddressScreenViewModelTests: XCTestCase {
                                                    userIndicatorController: UserIndicatorControllerMock())
         
         context.desiredAliasLocalPart = "room-name"
-
+        
         let publishingExpectation = expectation(description: "Wait for publishing")
         roomProxy.publishRoomAliasInRoomDirectoryClosure = { roomAlias in
             defer { publishingExpectation.fulfill() }