From ffec0020a4e821723bae270d7424fb425afd716c Mon Sep 17 00:00:00 2001 From: Olivier 'reivilibre Date: Thu, 27 Nov 2025 15:13:24 +0000 Subject: [PATCH] We don't know if there's a device ID --- crates/handlers/src/compat/login_sso_complete.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/handlers/src/compat/login_sso_complete.rs b/crates/handlers/src/compat/login_sso_complete.rs index 229eb993c..020ddd707 100644 --- a/crates/handlers/src/compat/login_sso_complete.rs +++ b/crates/handlers/src/compat/login_sso_complete.rs @@ -123,7 +123,8 @@ pub async fn get( user: &session.user, is_interactive: true, login_type: CompatLoginType::WebSso, - // TODO should we predict a replacement? + // We don't know if there's going to be a replacement until we received the device ID, + // which happens too late. session_replaced: false, session_counts, requester: mas_policy::Requester { @@ -254,7 +255,8 @@ pub async fn post( is_interactive: true, login_type: CompatLoginType::WebSso, session_counts, - // TODO should we predict a replacement? + // We don't know if there's going to be a replacement until we received the device ID, + // which happens too late. session_replaced: false, requester: mas_policy::Requester { ip_address: activity_tracker.ip(),