Commit Graph

205 Commits

Author SHA1 Message Date
Benoit Marty
aea5384f9b Fix warning 2023-06-27 19:43:03 +02:00
Benoit Marty
c964996d80 Improve preview for TimelineItemTextView 2023-06-27 19:43:03 +02:00
Benoit Marty
6a8d7cdda2 Add padding on TimelineItemFileView 2023-06-27 19:43:03 +02:00
Benoit Marty
c62f588369 Increase padding in error case 2023-06-27 19:43:03 +02:00
Benoit Marty
6330a797aa Ensure message bubble is .75f width screen ratio. Remove padding from LazyList and apply padding to content to ensure width is correctly computed.
Avoid using LocalConfiguration, its not working well with screenshot test.
2023-06-27 19:43:03 +02:00
Benoit Marty
f1681ce43c Fix dev issue. 2023-06-27 19:43:03 +02:00
Benoit Marty
67dfc9f173 Rename file. 2023-06-27 19:43:03 +02:00
Benoit Marty
d53a2d7473 Use new aTimelineItemReactions fun. 2023-06-27 19:43:03 +02:00
Benoit Marty
1b84d8e3ee Fix test compilation issue. 2023-06-27 19:43:03 +02:00
Benoit Marty
9fb10b4bf2 Bubble max width to 3/4 of the screen width 2023-06-27 19:43:03 +02:00
Benoit Marty
884aea1c80 Iterate on extra padding solution. 2023-06-27 19:43:03 +02:00
Benoit Marty
50945e987a Rework timestamp position.
Add extra empty text to message content to avoid timestamp to overlap the text.
2023-06-27 19:40:30 +02:00
Benoit Marty
d608c9b9c6 Increase padding for timestamp 2023-06-27 19:38:25 +02:00
Benoit Marty
b2e0f2eb68 Increase space between messages. 2023-06-27 19:38:25 +02:00
Benoit Marty
965e622032 Rework Message bubbles, to avoid using zIndex and offset. 2023-06-27 19:38:25 +02:00
Benoit Marty
89e3302f12 Rework avatar rendering of sender of message. 2023-06-27 19:38:25 +02:00
Benoit Marty
1ba2252dca Add missing previews. 2023-06-27 19:38:25 +02:00
Benoit Marty
e7bb896001 Change bubble background colors - also affects background of reactions. 2023-06-27 19:37:52 +02:00
Benoit Marty
d6f2d7a5d3 Rework AvatarSize.
Remove default value for AvatarSize, it has to be explicitely provided.
2023-06-27 19:23:37 +02:00
Jorge Martin Espinosa
02dc447624 [Compound] Integrate compound tokens (#586)
* Added tokens.

* Apply color to MaterialTheme, also add typography.

* Map colors to the right ones in the themes.

* Create and improve previews of some components

* More preview improvements

* Add `tertiary` and `onTertiary` colors, remove some unused ones.

* Fix usage of deleted color token

* Fix bug in Switch previews

* Create a separate `:libraries:theme` module to keep everything related to colors, typography and Compound in general.

* Fix `DatePickerPreview`

* Add missing Compound generated files by fixing their package name

* Move `ElementTheme` to the `:libraries:theme` module, make some variables internal.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-27 16:15:40 +00:00
Benoit Marty
d782162f27 Merge pull request #684 from vector-im/feature/bma/stringR
Quick PR to introduce `CommonStrings` type alias
2023-06-27 16:00:31 +02:00
Marco Romano
2a82e1b4e4 Async API improvements "v2" (#672)
* Async API improvements "v2"

**NB: This PR actually changes only 3 files in `libraries/architecture/`. All the other changes are automated refactors to fix the calling code.**

This is a proposal for improvements to our `Async` type as discussed in: https://github.com/vector-im/element-x-android/pull/598/files#r1230664392 and in other chats.

Please bear in mind it is just a proposal, I'd love to hear your feedback about it, especially when it comes to naming: I've tried to make parameter and function names use a terminology similar to what we find in the Kotlin stdlib and its `Result` type.

I'm inclined to like more the non-extension flavours of the new `run*` APIs, though I'd also like your feedback about what API shape you prefer.

### Summary of the changes:
#### Functional
- Adds `exceptionOrNull()` API to complement the existing `dataOrNull()` API.
- Adds `isFailure()`, `isLoading()`, `isSuccess()` and `isUninitialized()` courtesy APIs.
- Renames `executeResult()` to `runUpdatingState()`:
	- Becomes the base API to which all the other similarly named APIs call into.
	- Makes it inline.
	- Adds contract.
	- Passes over any `prevData` to newre Async states.
	- Passes through the `block`s return value.
	- Adds unit tests.
- Renames `execute` to `runCatchingUpdatingState()` and makes it just call into `runUpdatingState()`
- Adds extension function overloads to the `run*` functions to accept `MutableState` as receiver

#### Cosmetics
- Reorders classes and methods in alphabetic order.
- Reorder parameter names to mimic conventions in Kotlin stdlib.
- Adds docstrings where useful.

* Use `fold()`

* rename pop to popFirst

* Add docstrings

* Please Detekt

* Rename exception to error.

* Please detekt

* Update existing usages.
2023-06-27 13:37:23 +02:00
Benoit Marty
287328f7df More cleanup 2023-06-27 09:51:33 +02:00
Benoit Marty
4a8c49fa28 Use CommonStrings everywhere 2023-06-27 09:45:00 +02:00
Marco Romano
ffc9d1e82e Refine handleSnackbarMessage API (#676)
As per our offline convos during a PR review.
2023-06-26 16:29:50 +02:00
Benoit Marty
a226580c8c Move FileSizeFormatter to module :libraries:androidutils 2023-06-26 11:14:53 +02:00
Benoit Marty
df4bc3d7ce Improve rendering of cache size (and fix compilation issue) 2023-06-26 11:07:22 +02:00
Benoit Marty
ac60ef0cbe Move FileSizeFormatter to a new module for injectable Android utilities. 2023-06-26 11:06:36 +02:00
bmarty
9c5c578c67 Sync Strings from Localazy 2023-06-26 00:10:53 +00:00
Jorge Martin Espinosa
95f65e2031 [Message Actions] Copy events to clipboard (#665)
* Add `Copy` action for text events

* Remove 'Copy' action from the list for non-text events

* Use `@ContributesBinding` to inject `AndroidClipboardHelper`.
2023-06-23 14:39:07 +00:00
Jorge Martin Espinosa
bdb1841e44 [Message Actions] Report messages (#642)
* Add report messages feature

* Try to improve how snackbars are delivered

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-23 10:44:47 +02:00
Jorge Martin Espinosa
de7bbbd5cf [Message Actions] Forward messages (#635)
* Add forwarding messages base

* Make forwarding single-selection

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-22 13:27:59 +02:00
ganfra
b3e11d184a CanSendEvent default to true and branch refresh mechanism... 2023-06-21 17:43:08 +02:00
Benoit Marty
4b55641aae Merge pull request #631 from vector-im/feature/bma/sendPermission
Take into acount send permission (power level)
2023-06-21 11:35:33 +02:00
Benoit Marty
02c56df991 Extract getCanSendEvent to the matrixui module, rename to canSendEventAsState and use produceState. 2023-06-21 10:57:55 +02:00
ganfra
c3b2db47bd Merge pull request #617 from vector-im/feature/fga/fix_media_pre_processing
Feature/fga/fix media pre processing
2023-06-20 16:17:50 +02:00
bmarty
2faa96a4e4 Sync Strings from Localazy 2023-06-19 20:15:52 +00:00
ganfra
07a2d309c4 Timeline media: kind of align with other messenger apps 2023-06-19 21:38:54 +02:00
github-actions[bot]
3f7738c001 Sync Strings (#630)
* Sync Strings from Localazy

* Update strings, remove broken German translation

* Update screenshots

---------

Co-authored-by: bmarty <bmarty@users.noreply.github.com>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-19 11:18:01 +00:00
Benoit Marty
dfcbb33c0a Display a banner instead of the composer when user cannot post message to a room (#602) 2023-06-19 11:52:34 +02:00
ganfra
7f8250106c Media : Fix test compilation 2023-06-16 14:23:52 +02:00
ganfra
e7ad8f6e07 Merge branch 'develop' into feature/fga/fix_media_pre_processing 2023-06-16 14:05:11 +02:00
ganfra
b6e7228ce0 Fix MediaPreProcessor for images/videos sent as file 2023-06-16 13:52:07 +02:00
ganfra
dcb9bcd11e Timeline: fix unknown aspectRatio 2023-06-15 22:50:01 +02:00
ganfra
a900721c0e Merge pull request #603 from vector-im/feature/fga/update-rust-sdk-0.1.20
Matrix rust sdk: update to 0.1.20 (and fix compilation issues)
2023-06-15 16:35:45 +02:00
Benoit Marty
e907d610c2 Merge pull request #591 from vector-im/feature/bma/noDelayInTests
No delay in tests
2023-06-15 15:27:41 +02:00
ganfra
170c741130 Matrix rust sdk: update to 0.1.20 (and fix compilation issues) 2023-06-15 15:26:53 +02:00
Jorge Martin Espinosa
9bdf53f43d Move logic of different BottomSheets in MessagesView to presenters (#600)
* Move bottom sheet logic in `MessagesView` to presenters.

* Make the block inside `SheetState.hide` suspend.
2023-06-15 14:58:18 +02:00
ganfra
9be0587b8b Merge pull request #599 from vector-im/feature/fga/timeline_media_improvements
Feature/fga/timeline media improvements
2023-06-15 14:36:15 +02:00
ganfra
8207098091 Timeline: use thumbnailSource for image if available (except for gif) 2023-06-15 12:11:37 +02:00