Commit Graph

538 Commits

Author SHA1 Message Date
Benoit Marty
30cea9c70a Always use the latest... fix. 2024-01-23 18:13:33 +01:00
Benoit Marty
cff076b508 Fix detekt issue:
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
2024-01-23 18:13:33 +01:00
Jorge Martin Espinosa
27ddc4ec74 Upgrade Material3 Compose to 1.2.0-beta02 (#2247)
* Upgrade Material3 Compose to `1.2.0-beta02`.

There is also a constraint on a transitive Compose Foundation dependency version (1.6.0-beta02) that fixes the timeline scrolling issue.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-18 08:49:55 +01:00
Benoit Marty
a926b3d390 Merge branch 'develop' into feature/bma/sxcludePreviewFromCodeCoverage 2024-01-11 16:02:58 +01:00
Benoit Marty
d3830af78b Fix ktlint issues 2024-01-10 19:33:39 +01:00
Benoit Marty
7b699d96c0 Ignore ktlint issue for this particular object. 2024-01-10 19:31:36 +01:00
renovate[bot]
7e9cda3aa9 Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Jorge Martin Espinosa
e762584a37 Improve rendering of voice messages in the timeline in large displays (#2199)
* Improve rendering of voice messages in the timeline in large displays

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-09 18:07:23 +01:00
Benoit Marty
7fbe848243 Exclude ContentToPreview from coverage, either by using annotation @ExcludeFromCoverage, or by inlining it. 2024-01-09 17:56:01 +01:00
ganfra
2f49de1fbb Rename SearchBarResultState.Empty to SearchBarResultState.Initial 2024-01-05 15:40:02 +01:00
ganfra
2a240d2496 Merge branch 'develop' into feature/fga/invite_user_loader 2024-01-05 14:02:58 +01:00
ganfra
690a165411 User search : show a loader when fetching results 2024-01-04 21:27:44 +01:00
Benoit Marty
1dc6e5edb3 Clean up 2024-01-04 18:45:34 +01:00
Benoit Marty
b466ade6a1 Rename parameter 2024-01-04 18:10:53 +01:00
Benoit Marty
d78ce21939 Rename AsyncView to AsyncActionView 2024-01-04 17:50:52 +01:00
Benoit Marty
bd91dd64e2 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
Jorge Martin Espinosa
4f296ffb49 Disable vector XML rasterisation on API 23 (#2128)
* Disable vector XML rasterisation on API 23

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-12-29 11:41:08 +00:00
Benoit Marty
cc50d45141 Use icon from library and move and rename retry.xml to the library.
Also fix contentDescription for pause button.
2023-12-20 17:33:49 +01:00
Benoit Marty
8f753a8a91 Use Edit icon from Compound and delete ic_edit_solid 2023-12-20 17:33:49 +01:00
Benoit Marty
f7f71ddf4a Use Thread icon from Compound and delete ic_thread_decoration 2023-12-20 17:33:49 +01:00
Benoit Marty
184e9928f5 Use CompoundIcon and remove ic_send.xml 2023-12-20 17:33:49 +01:00
Benoit Marty
6a9bcb8d1e Format 2023-12-20 17:33:49 +01:00
Benoit Marty
39298a22f3 Use VideoCallSolid and also delete local ic_video_call.xml icon. 2023-12-20 17:33:49 +01:00
Benoit Marty
9f6e59db8f Change name to match use case. 2023-12-19 13:42:07 +01:00
Benoit Marty
bc4da250e1 Also linkify emails. 2023-12-15 20:07:11 +01:00
Benoit Marty
6bf416045d Merge branch 'develop' into julioromano/poll_history_entry_point 2023-12-14 16:58:23 +01:00
ganfra
3ceb2599d8 Merge branch 'develop' into julioromano/poll_history_entry_point 2023-12-14 15:17:13 +01:00
Jorge Martin Espinosa
e31b85f6c5 Fix mentions font weight and horizontal padding (#2025)
* Fix mentions font weight and horizontal padding

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-12-14 14:15:25 +01:00
Benoit Marty
ad57fcbd8a Accessibility: do not read initial used for avatar out loud. (#1864) 2023-12-13 12:07:33 +01:00
ganfra
e263ea27a0 Theme : introduce SegmentedButton 2023-12-06 19:28:04 +01:00
Jorge Martin Espinosa
a8b85fb4e6 Extract compound tokens and theming to compound-android library (#1888)
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-27 10:30:07 +01:00
Benoit Marty
d29219169a Merge pull request #1862 from vector-im/feature/bma/moreTests
Remove lambda default value
2023-11-24 11:00:34 +01:00
Jorge Martin Espinosa
b1f2370e72 Run 'record screenshots' flow if label is present (#1860)
* Run 'record screenshots' flow if label is present

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-23 08:25:33 +01:00
Benoit Marty
ec2fa8b5a2 Merge pull request #1845 from vector-im/feature/bma/sendingStateA11y
Content description: add for sending state and fix other issues.
2023-11-22 17:51:48 +01:00
Benoit Marty
4ae0790cc1 Remove default value for lambda.
We enforce a value to be provided and it's better for code coverage.
2023-11-22 17:28:23 +01:00
Marco Romano
202173c8e3 Update poll icons from Compound (#1849)
* Use compound icons for polls

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-22 13:35:04 +01:00
Benoit Marty
806a5193d3 Replace Alertdialog (deprecated) by BasicAlertDialog. 2023-11-21 17:22:53 +01:00
Benoit Marty
16186f74f1 Fix compilation warning, add opt in for ExperimentalMaterial3Api 2023-11-21 16:39:38 +01:00
Benoit Marty
5f8e85edc6 Prevent usage of hard-coded string for contentDescription, and fix existing issues. 2023-11-21 15:38:21 +01:00
Benoit Marty
4ec81721dd Fix some contentDescription. 2023-11-21 14:44:38 +01:00
Jorge Martin Espinosa
b8ee82a912 Integrate mentions in the composer (#1799)
* Integrate mentions in the composer:

    - Add `MentionSpanProvider`.
    - Add custom colors needed for mentions.
    - Use the span provider to render mentions in the composer.
    - Allow selecting users from the mentions suggestions to insert a mention.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-20 18:14:02 +01:00
Benoit Marty
84f61170d8 Read receipt: Improve accessibility 2023-11-17 16:40:53 +01:00
Benoit Marty
d5d002ce5d Read receipt: Bottom sheet 2023-11-16 14:05:00 +01:00
Benoit Marty
3e0971f189 Read receipt: model and UI. 2023-11-16 14:05:00 +01:00
Jorge Martin Espinosa
14cf2b0440 Iterate design on several screens: update icons, replace PreferenceTexts (#1771)
- Batch import new icons from the design team.
- Rename _september icons since they're just extra icons that need to be integrated in Compound in the future, and it should be ok if we don't distinguish between ic_september_*, ic_november_* etc., so all icons are now simply ic_* in the designsystem module.
- Create a new CompoundIconListPreviewProvider to add chunked lists of icons for previews. Add an exception for it to Konsist.
- Move some icons to use Compound icons.
- Remove most PreferenceText usages, use ListItem instead.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-15 10:52:37 +01:00
jonnyandrew
53f03335c3 Update voice message recording button behaviour (#1784)
Changes recording button behaviour so that
- tapping the record button starts a recording and displays the stop button
- tapping the stop button stops the recording
- tapping the delete button cancels the recording
- 'hold to record' tooltip is removed


---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-14 14:05:59 +00:00
Benoit Marty
8c53dd435b Ensure the size of the icon is 20.dp 2023-11-09 15:22:23 +01:00
Benoit Marty
eabc3f82ae Move icons to the design system to reuse them (and use new ic_devices). 2023-11-09 15:09:42 +01:00
Jorge Martin Espinosa
5bb8efb728 Iterate design on Settings screen (#1763)
* Iterate design on Settings screen:

- Set new icons provided by design.
- Replace `PreferenceText` usages with `ListItem`.
- Add missing icons, and a new way to group them for previews.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-08 11:31:17 +01:00
Benoit Marty
6d8386307b FlowStepPage: make onBackClicked nullable and remove canGoBack. 2023-11-07 10:59:22 +01:00