Commit Graph

117 Commits

Author SHA1 Message Date
Benoit Marty
5047136a7b Merge pull request #983 from vector-im/feature/bma/lintErrors
Update lint rules, remove unused resource and sync strings.
2023-07-27 15:59:38 +02:00
Benoit Marty
952238d5fe Detect missing translations. 2023-07-27 13:25:37 +02:00
Benoit Marty
d78e1d3207 lint: ImpliedQuantity is now error. 2023-07-27 11:55:49 +02:00
Benoit Marty
3dda01a08a lint: remove unknown rule. 2023-07-27 11:54:51 +02:00
Benoit Marty
5ab76eefe3 Lint: do not ignore unused resources (except for strings) 2023-07-27 11:42:23 +02:00
Benoit Marty
eac0d76782 Add Localazy badge to the Localazy readme. 2023-07-26 15:12:58 +02:00
Benoit Marty
de7866be19 Ensure the release script will exist in case of failure. 2023-07-21 12:51:10 +02:00
Benoit Marty
03b2b0d484 Add a shortcut to ensure that ./gradlew check will prevent having warning in the codebase. We may add more instructions in the future in this file. 2023-07-21 12:50:29 +02:00
Benoit Marty
59a66479ab Merge branch 'develop' into feature/bma/noWarnings 2023-07-21 12:17:50 +02:00
Benoit Marty
aa26959748 Change how we detect if git flow is init. 2023-07-20 19:43:46 +02:00
Benoit Marty
1bc80a526c Move download_github_artifacts.py to its own folder. 2023-07-20 19:22:53 +02:00
Benoit Marty
c56977ed69 Extract git flow init from release script (so that it can be run standalone) and do not use -t which does not seem to be standard. 2023-07-20 19:15:56 +02:00
Benoit Marty
4a3ba10ad5 Enable more detekt rules 2023-07-20 18:08:37 +02:00
Benoit Marty
c72f1a09a7 Enable detekt rules UnnecessaryParentheses and cleanup the code. 2023-07-20 18:08:08 +02:00
Benoit Marty
55538c2773 Enable detekt rules UnusedImports and cleanup the code. 2023-07-20 18:00:23 +02:00
Benoit Marty
2c4308ddba Remove detekt rules about ViewModels. 2023-07-20 17:53:29 +02:00
Benoit Marty
8f715cbc92 Enable detekt rules TopLevelPropertyNaming and cleanup the code. 2023-07-20 17:52:48 +02:00
Benoit Marty
2bd1c75937 Enable detekt rules VariableNaming and cleanup the code. 2023-07-20 17:50:23 +02:00
Benoit Marty
bd2826da3a Enable detekt rules UnusedParameter and UnusedPrivateProperty and cleanup the code. 2023-07-20 17:48:56 +02:00
Benoit Marty
bb3511e5f3 Enable detekt rule UnusedPrivateMember and cleanup the code. 2023-07-20 17:44:14 +02:00
Benoit Marty
14507c9cbc Add release script 2023-07-20 13:27:47 +02:00
Jorge Martin Espinosa
280b7e32e0 Hide encryption history + FTUE flow (#839)
* First attempt at implementing encrypted history banner and removing old UTDs

* Get the right behavior in the timeline

* Implement the designs

* Extract post-processing logic, add tests

* Add encryption banner to timeline screenshots

* Create FTUE feature to handle welcome screen and analytics

* Move classes to their own packages, add tests for `DefaultFtueState`.

* Remove unnecessary private MutableStateFlow

* Move some FTUE related methods and classes back to the `impl` module

* Handle back press at each FTUE step

* Remove unneeded `TestScope` receiver for `createState` in tests.

* Use light & dark previews for the banner view.

* Move color customization from `TextStyle` to `Text` component.

* Rename `InfoList` design components, use them in `AnalyticsOptInView` too.

* Cleanup MatrixClient.

* Fix copy&paste error

Co-authored-by: Benoit Marty <benoit@matrix.org>

* Fix typo

* Fix Maestro tests

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
Co-authored-by: Benoit Marty <benoit@matrix.org>
2023-07-17 18:34:36 +02:00
Marco Romano
a852465554 MapLibre compose wrapper library (#877)
Heavily inspired from https://github.com/googlemaps/android-maps-compose It doesn't aim to be a full featured library like android-maps-compose, it's been stripped down to only handle our use cases.

Related to:
https://github.com/vector-im/element-meta/issues/1674
https://github.com/vector-im/element-meta/issues/1682
2023-07-17 16:22:29 +02:00
Benoit Marty
9b042cf056 Remove ElementColors. We should use semantics and material colors now. 2023-07-10 17:33:42 +02:00
Benoit Marty
47240e208b Remove the legacy script which imports Strigns from Element Android project. 2023-07-10 12:15:41 +02:00
Benoit Marty
4e8725d390 Merge pull request #781 from vector-im/feature/bma/waitingListScreen
Implement waiting list screen (error IO_ELEMENT_X_WAIT_LIST)
2023-07-06 18:24:41 +02:00
Marco Romano
aed4b92761 Optional day night preview annotation (#793)
Adds the `@DayNightPreviews` annotation that when used on a composable will:
- Display both a day mode and night mode preview in Android Studio.
- Produce both a day and night screenshot during screenshot testing.

The usage of this new annotation is optional, all the current previews continue to work without breakages.
New code can use, when appropriate, the new `@DayNightPreviews` annotation and replace the pattern using three `LightPreview/DarkPreview/ContentToPreview` functions with:

```
@DayNightPreviews
@Composable
fun MyScreenPreview(@PreviewParameter(MyStateProvider::class) state: MyState) {
    ElementPreview {
        MyScreen(
            state = state,
        )
    }
}
```
2023-07-06 12:35:54 +02:00
Benoit Marty
4ba4e92575 Move string screen_waitlist_ to module login. 2023-07-05 15:53:28 +02:00
Marco Romano
f33561c25d Revert "Auto generate dark mode previews and screenshots (#776)" (#784)
This reverts commit 79b529193c.
2023-07-05 15:47:53 +02:00
Marco Romano
79b529193c Auto generate dark mode previews and screenshots (#776)
With this change, composable previews and screenshots should be created with just:
```
@ElementPreviews
@Composable
fun MyViewPreview() {
    ElementPreview { 
        MyView()
    }
}
```

- Adds `@ElementPreviews` which is a shorthand for:
```
@Preview(name = "D")
@Preview(name = "N", uiMode = Configuration.UI_MODE_NIGHT_YES)
```
Should be used in connection with the now public `fun ElementPreview()` composable.

- Adds ElementPreviews to previewAnnotations in dangerfile
- Screenshots of night mode previews are now rendered with night mode
- Replaces `ElementPreviewLight` and `ElementThemedPreview` with `ElementPreview`
- Deprecates `ElementPreviewDark` which should be removed.
- Remaining usages of `ElementPreviewDark` are now ignored during screenshot tests
2023-07-05 13:58:24 +02:00
Benoit Marty
d33ce449ea Fix false positive. 2023-07-03 17:09:04 +02:00
Jorge Martin Espinosa
c5a5810c05 Link Compound's TypographyTokens to ElementTheme. (#700)
* Link Compound's `TypographyTokens` to `ElementTheme`.

Also add some docs about when we should use each set of tokens.

* Renamed `LocalColors` to `LocalLegacyColors`.

Made both `LocalLegacyColors` and `LocalCompoundColors` internal. This means it will need to always be used through `ElementTheme.`

Also, removed any usages of `LocalColors.current` accross the project, they're now used through `ElementTheme.legacyColors`.
2023-06-28 08:53:20 +00:00
Benoit Marty
d782162f27 Merge pull request #684 from vector-im/feature/bma/stringR
Quick PR to introduce `CommonStrings` type alias
2023-06-27 16:00:31 +02:00
Chris Smith
0eb195560b Danger: remove "add screenshots" warning (#691)
We have screenshot tests that basically negate the need for this,
and when we're doing more complicated things we tend to use
videos anyway which aren't caught by this check.
2023-06-27 15:37:44 +02:00
Benoit Marty
1a216d5a57 Update check rule. 2023-06-27 09:55:14 +02:00
Jorge Martin Espinosa
bdb1841e44 [Message Actions] Report messages (#642)
* Add report messages feature

* Try to improve how snackbars are delivered

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-06-23 10:44:47 +02:00
Benoit Marty
7dea3c1dd2 Ensure files downloaded by localazy end with a new line. 2023-06-16 15:14:00 +02:00
Benoit Marty
18f32e51b4 Prevent direct usage of io.element.android.libraries.ui.strings.R package. 2023-06-09 18:24:51 +02:00
Benoit Marty
06297bb792 Update strings. 2023-06-09 16:34:22 +02:00
Benoit Marty
9809969b64 Account provider screen. - Crashing 2023-06-07 09:00:20 +02:00
Benoit Marty
96f9eb8397 Change account provider screen. 2023-06-07 09:00:20 +02:00
Yoan Pintas
d2263372d2 Init analytics modules (#350) 2023-06-05 13:11:34 +00:00
Chris Smith
09411f8993 Danger: don't complain about reviewers (#509)
Now we have a CODEOWNERS file a reviewer is assigned automatically,
so there's no need for this.

It also misfires a bunch (maybe if there are no _pending_ reviewers
because they've already reviewed?), so removing it fixes that noise.
2023-06-01 14:02:28 +00:00
Jorge Martin Espinosa
b218dbd237 Merge pull request #501 from vector-im/misc/jme/remove-duplicate-danger-reports
Remove duplicate issue reporting by Danger
2023-06-01 12:15:37 +02:00
Benoit Marty
b9494d2492 Merge pull request #494 from vector-im/feature/bma/checkCode
Check code
2023-06-01 11:53:53 +02:00
Jorge Martín
3f65200ba0 Remove duplicate issue reporting by Danger 2023-06-01 11:04:52 +02:00
Benoit Marty
7054224451 Search for forbidden patterns in Kotlin files. 2023-05-31 15:30:18 +02:00
Benoit Marty
4eecb569c9 Fix test script 2023-05-30 15:59:58 +02:00
Benoit Marty
4c9bed9d8a Oidc with CustomTab 2023-05-30 15:59:58 +02:00
renovate[bot]
7ba3d3d1ab Update dependency io.gitlab.arturbosch.detekt to v1.23.0 (#454)
* Update dependency io.gitlab.arturbosch.detekt to v1.23.0

* Disable new detekt rules for unused params

UnusedParameter and UnusedPrivateProperty are both potentially
useful but we currently break them a lot, for the most part
in places that haven't been fully implemented yet.

The unused params are reported as build warnings anyway, so
we're not missing much by disabling these for now.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Chris Smith <csmith@lunarian.uk>
2023-05-30 11:18:51 +00:00