From ff697f68fc21eabec68d5bc3b4dfe453c538d4db Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 30 May 2024 15:12:27 +0200
Subject: [PATCH] Ensure that we can "not filter" the rooms.

---
 .../android/libraries/matrix/api/roomlist/RoomListFilter.kt | 2 ++
 .../libraries/matrix/impl/roomlist/RoomListFilterTest.kt    | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/roomlist/RoomListFilter.kt b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/roomlist/RoomListFilter.kt
index 8f5526a6e0..4af0e463fd 100644
--- a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/roomlist/RoomListFilter.kt
+++ b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/roomlist/RoomListFilter.kt
@@ -20,6 +20,7 @@ sealed interface RoomListFilter {
     companion object {
         /**
          * Create a filter that matches all the given filters.
+         * If not filters are provided, all the room will match.
          */
         fun all(vararg filters: RoomListFilter): RoomListFilter {
             return All(filters.toList())
@@ -35,6 +36,7 @@ sealed interface RoomListFilter {
 
     /**
      * A filter that matches all the given filters.
+     * If [filters] is empty, all the room will match.
      */
     data class All(
         val filters: List<RoomListFilter>
diff --git a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomlist/RoomListFilterTest.kt b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomlist/RoomListFilterTest.kt
index 0916480c9e..02fb9cd24b 100644
--- a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomlist/RoomListFilterTest.kt
+++ b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/roomlist/RoomListFilterTest.kt
@@ -136,4 +136,10 @@ class RoomListFilterTest {
         )
         assertThat(roomSummaries.filter(filter)).isEmpty()
     }
+
+    @Test
+    fun `Room list filter all with empty list`() = runTest {
+        val filter = RoomListFilter.all()
+        assertThat(roomSummaries.filter(filter)).isEqualTo(roomSummaries)
+    }
 }