From fb5ab95401cfb81eda301d611fb366c0fd811571 Mon Sep 17 00:00:00 2001 From: Jorge Martin Espinosa Date: Thu, 21 Mar 2024 12:51:43 +0100 Subject: [PATCH] Fix Poll history 'Load more' button alignment (#2577) * Fix Poll history 'Load more' button alignment * Update screenshots --------- Co-authored-by: ElementBot --- .../features/poll/impl/history/PollHistoryStateProvider.kt | 5 +++++ .../android/features/poll/impl/history/PollHistoryView.kt | 1 + ...w_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png | 3 +++ ...null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png | 3 +++ 4 files changed, 12 insertions(+) create mode 100644 tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png create mode 100644 tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png diff --git a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryStateProvider.kt b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryStateProvider.kt index be06d744d1..08b993f6df 100644 --- a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryStateProvider.kt +++ b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryStateProvider.kt @@ -41,6 +41,11 @@ class PollHistoryStateProvider : PreviewParameterProvider { activeFilter = PollHistoryFilter.PAST, currentItems = emptyList(), ), + aPollHistoryState( + activeFilter = PollHistoryFilter.PAST, + currentItems = emptyList(), + hasMoreToLoad = true, + ), ) } diff --git a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryView.kt b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryView.kt index 69eed21b43..466ddc54f9 100644 --- a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryView.kt +++ b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/history/PollHistoryView.kt @@ -191,6 +191,7 @@ private fun PollHistoryList( Column( modifier = Modifier.fillParentMaxSize().padding(bottom = 24.dp), verticalArrangement = Arrangement.Center, + horizontalAlignment = Alignment.CenterHorizontally, ) { val emptyStringResource = if (filter == PollHistoryFilter.PAST) { stringResource(R.string.screen_polls_history_empty_past) diff --git a/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png new file mode 100644 index 0000000000..0501f776a0 --- /dev/null +++ b/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Day-1_2_null_4,NEXUS_5,1.0,en].png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:821058570014a0418b22eb4119122b595f802cabeffcabe30c9085b1485ab2c2 +size 19568 diff --git a/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png b/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png new file mode 100644 index 0000000000..9a6415ef7e --- /dev/null +++ b/tests/uitests/src/test/snapshots/images/ui_S_t[f.poll.impl.history_PollHistoryView_null_PollHistoryView-Night-1_3_null_4,NEXUS_5,1.0,en].png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +oid sha256:a174fd40ab7fa21541c6cf2e25edbe3f286c5aaf7103ec8cf6c4dbc94bba373e +size 18512