Change in clear cache behavior:
- Do not reset the analytics store, so that we do not ask the user consent again => Parity with iOS. - Do not reset the permission store, because it contains information that's related to the system permission, which cannot be retrieved otherwise => Should help with #3195.
This commit is contained in:
committed by
Benoit Marty
parent
bb5ef7a62c
commit
f683728f35
@@ -16,6 +16,4 @@ interface PermissionStateProvider {
|
||||
|
||||
suspend fun setPermissionAsked(permission: String, value: Boolean)
|
||||
fun isPermissionAsked(permission: String): Flow<Boolean>
|
||||
|
||||
suspend fun resetPermission(permission: String)
|
||||
}
|
||||
|
||||
@@ -40,6 +40,4 @@ class DefaultPermissionStateProvider(
|
||||
override suspend fun setPermissionAsked(permission: String, value: Boolean) = permissionsStore.setPermissionAsked(permission, value)
|
||||
|
||||
override fun isPermissionAsked(permission: String): Flow<Boolean> = permissionsStore.isPermissionAsked(permission)
|
||||
|
||||
override suspend fun resetPermission(permission: String) = permissionsStore.resetPermission(permission)
|
||||
}
|
||||
|
||||
@@ -15,7 +15,6 @@ class FakePermissionStateProvider(
|
||||
private var permissionGranted: Boolean = true,
|
||||
permissionDenied: Boolean = false,
|
||||
permissionAsked: Boolean = false,
|
||||
private val resetPermissionLambda: (String) -> Unit = {},
|
||||
) : PermissionStateProvider {
|
||||
private val permissionDeniedFlow = MutableStateFlow(permissionDenied)
|
||||
private val permissionAskedFlow = MutableStateFlow(permissionAsked)
|
||||
@@ -37,10 +36,4 @@ class FakePermissionStateProvider(
|
||||
}
|
||||
|
||||
override fun isPermissionAsked(permission: String): Flow<Boolean> = permissionAskedFlow
|
||||
|
||||
override suspend fun resetPermission(permission: String) {
|
||||
setPermissionAsked(permission, false)
|
||||
setPermissionDenied(permission, false)
|
||||
resetPermissionLambda(permission)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user