letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

Remove dead code AnalyticsService.onSignOut.

Browse Source 
DefaultAnalyticsService is observing the Session.
This commit is contained in:
Benoit Marty
2024-05-28 17:36:24 +02:00
committed by Benoit Marty
parent 6acc86641a
commit d4e6b4fa1d
3 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/AnalyticsService.kt
View File

@@ -57,11 +57,6 @@ interface AnalyticsService : AnalyticsTracker, ErrorTracker {
*/ */
suspend fun setAnalyticsId(analyticsId: String) suspend fun setAnalyticsId(analyticsId: String)
/**
* To be called when a session is destroyed.
*/
suspend fun onSignOut()
/** /**
* Reset the analytics service (will ask for user consent again). * Reset the analytics service (will ask for user consent again).
*/ */

5
services/analytics/impl/src/main/kotlin/io/element/android/services/analytics/impl/DefaultAnalyticsService.kt
View File

@@ -91,11 +91,6 @@ class DefaultAnalyticsService @Inject constructor(
analyticsStore.setAnalyticsId(analyticsId) analyticsStore.setAnalyticsId(analyticsId)
} }
override suspend fun onSignOut() {
// stop all providers
analyticsProviders.onEach { it.stop() }
}
override suspend fun onSessionCreated(userId: String) { override suspend fun onSessionCreated(userId: String) {
// Nothing to do // Nothing to do
} }

1
services/analytics/noop/src/main/kotlin/io/element/android/services/analytics/noop/NoopAnalyticsService.kt
View File

@@ -38,7 +38,6 @@ class NoopAnalyticsService @Inject constructor() : AnalyticsService {
override suspend fun setDidAskUserConsent() = Unit override suspend fun setDidAskUserConsent() = Unit
override fun getAnalyticsId(): Flow<String> = flowOf("") override fun getAnalyticsId(): Flow<String> = flowOf("")
override suspend fun setAnalyticsId(analyticsId: String) = Unit override suspend fun setAnalyticsId(analyticsId: String) = Unit
override suspend fun onSignOut() = Unit
override suspend fun reset() = Unit override suspend fun reset() = Unit
override fun capture(event: VectorAnalyticsEvent) = Unit override fun capture(event: VectorAnalyticsEvent) = Unit
override fun screen(screen: VectorAnalyticsScreen) = Unit override fun screen(screen: VectorAnalyticsScreen) = Unit