Ensure Posthog is only used for Element builds.

This commit is contained in:
Benoit Marty
2024-06-04 17:04:19 +02:00
parent c156b7d520
commit c9c0413c40
3 changed files with 32 additions and 4 deletions

View File

@@ -0,0 +1,28 @@
/*
* Copyright (c) 2024 New Vector Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.element.android.libraries.core.extensions
import io.element.android.libraries.core.meta.BuildMeta
import io.element.android.libraries.core.meta.BuildType
fun BuildMeta.isElement(): Boolean {
return when (buildType) {
BuildType.RELEASE -> applicationId == "io.element.android.x"
BuildType.NIGHTLY -> applicationId == "io.element.android.x.nightly"
BuildType.DEBUG -> applicationId == "io.element.android.x.debug"
}
}

View File

@@ -20,6 +20,7 @@ import android.content.Context
import com.posthog.PostHogInterface
import com.posthog.android.PostHogAndroid
import com.posthog.android.PostHogAndroidConfig
import io.element.android.libraries.core.extensions.isElement
import io.element.android.libraries.core.meta.BuildMeta
import io.element.android.libraries.di.ApplicationContext
import javax.inject.Inject
@@ -29,7 +30,8 @@ class PostHogFactory @Inject constructor(
private val buildMeta: BuildMeta,
private val posthogEndpointConfigProvider: PosthogEndpointConfigProvider,
) {
fun createPosthog(): PostHogInterface {
fun createPosthog(): PostHogInterface? {
if (!buildMeta.isElement()) return null
val endpoint = posthogEndpointConfigProvider.provide()
return PostHogAndroid.with(
context,

View File

@@ -47,7 +47,7 @@ class PosthogAnalyticsProvider @Inject constructor(
private val userPropertiesLock = Any()
override fun init() {
posthog = createPosthog()
posthog = postHogFactory.createPosthog()
posthog?.optIn()
// Timber.e("PostHog distinctId: ${posthog?.distinctId()}")
identifyPostHog()
@@ -108,8 +108,6 @@ class PosthogAnalyticsProvider @Inject constructor(
// Not implemented
}
private fun createPosthog(): PostHogInterface = postHogFactory.createPosthog()
private fun identifyPostHog() {
val id = analyticsId ?: return
if (id.isEmpty()) {