From c79962f58c6e84caa586e717c507414afad35537 Mon Sep 17 00:00:00 2001
From: ganfra <francoisg@matrix.org>
Date: Mon, 2 Dec 2024 10:55:38 +0100
Subject: [PATCH] knock requests : allow reason to be expanded

---
 .../list/KnockRequestsListStateProvider.kt    | 11 +++++
 .../impl/list/KnockRequestsListView.kt        | 42 +++++++++++++++++--
 2 files changed, 49 insertions(+), 4 deletions(-)

diff --git a/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt b/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt
index 5a94a000ae..7b7b1e4f5e 100644
--- a/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt
+++ b/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListStateProvider.kt
@@ -33,6 +33,17 @@ open class KnockRequestsListStateProvider : PreviewParameterProvider<KnockReques
                     )
                 ),
             ),
+            aKnockRequestsListState(
+                knockRequests = AsyncData.Success(
+                    persistentListOf(
+                        aKnockRequest(
+                            reason = "A very long reason that should probably be truncated, " +
+                                "but could be also expanded so you can see it over the lines, wow," +
+                                "very amazing reason, I know, right, I'm so good at writing reasons."
+                        )
+                    )
+                ),
+            ),
             aKnockRequestsListState(
                 knockRequests = AsyncData.Success(
                     persistentListOf(
diff --git a/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListView.kt b/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListView.kt
index de08550d9c..2d9480a02e 100644
--- a/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListView.kt
+++ b/features/knockrequests/impl/src/main/kotlin/io/element/android/features/knockrequests/impl/list/KnockRequestsListView.kt
@@ -7,7 +7,9 @@
 
 package io.element.android.features.knockrequests.impl.list
 
+import androidx.compose.animation.animateContentSize
 import androidx.compose.foundation.background
+import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
@@ -18,12 +20,17 @@ import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.itemsIndexed
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableStateOf
+import androidx.compose.runtime.saveable.rememberSaveable
+import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clipToBounds
@@ -51,6 +58,7 @@ import io.element.android.libraries.designsystem.theme.aliasScreenTitle
 import io.element.android.libraries.designsystem.theme.components.Button
 import io.element.android.libraries.designsystem.theme.components.ButtonSize
 import io.element.android.libraries.designsystem.theme.components.HorizontalDivider
+import io.element.android.libraries.designsystem.theme.components.Icon
 import io.element.android.libraries.designsystem.theme.components.OutlinedButton
 import io.element.android.libraries.designsystem.theme.components.Scaffold
 import io.element.android.libraries.designsystem.theme.components.Text
@@ -236,10 +244,36 @@ private fun KnockRequestItem(
             // Reason
             if (!knockRequest.reason.isNullOrBlank()) {
                 Spacer(modifier = Modifier.height(12.dp))
-                Text(
-                    text = knockRequest.reason,
-                    style = ElementTheme.typography.fontBodyMdRegular,
-                )
+                var isExpanded by rememberSaveable(knockRequest.userId) { mutableStateOf(false) }
+                var isExpandable by rememberSaveable(knockRequest.userId) { mutableStateOf(false) }
+                Row(
+                    verticalAlignment = Alignment.Top,
+                    modifier = Modifier
+                        .animateContentSize()
+                        .clickable(enabled = isExpandable) { isExpanded = !isExpanded }
+                ) {
+                    Text(
+                        text = knockRequest.reason,
+                        style = ElementTheme.typography.fontBodyMdRegular,
+                        maxLines = if (isExpanded) Int.MAX_VALUE else 3,
+                        onTextLayout = { result ->
+                            if (!isExpanded && result.hasVisualOverflow) {
+                                isExpandable = true
+                            }
+                        },
+                        overflow = TextOverflow.Ellipsis,
+                        modifier = Modifier.weight(1f),
+                    )
+                    Box(modifier = Modifier.size(24.dp)) {
+                        if (isExpandable) {
+                            Icon(
+                                imageVector = if (isExpanded) CompoundIcons.ChevronUp() else CompoundIcons.ChevronDown(),
+                                contentDescription = null,
+                                tint = ElementTheme.colors.iconTertiary,
+                            )
+                        }
+                    }
+                }
             }
             // Actions
             if (canDecline || canAccept) {