From bd58d85b698cde3d37b8bb0f5fe7bfbfccd2a72c Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 4 Dec 2023 15:26:32 +0100 Subject: [PATCH] Add Konsist test to use isEmpty() instead of isEqualTo(empty), and fix existing issue. --- .../features/call/MapWebkitPermissionsTest.kt | 2 +- .../element/android/tests/konsist/KonsistTestTest.kt | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt b/features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt index 55b5f16771..16414e66d3 100644 --- a/features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt +++ b/features/call/src/test/kotlin/io/element/android/features/call/MapWebkitPermissionsTest.kt @@ -39,7 +39,7 @@ class MapWebkitPermissionsTest { @Test fun `given any other permission, it returns nothing`() { val permission = mapWebkitPermissions(arrayOf(PermissionRequest.RESOURCE_PROTECTED_MEDIA_ID)) - assertThat(permission).isEqualTo(emptyList()) + assertThat(permission).isEmpty() } } diff --git a/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt index 6d21dc82b8..b8638f2521 100644 --- a/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt +++ b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistTestTest.kt @@ -86,4 +86,16 @@ class KonsistTestTest { functionDeclaration.text.contains("isEqualTo(true)") } } + + @Test + fun `use isEmpty() instead of isEqualTo(empty)`() { + Konsist + .scopeFromTest() + .functions() + // Exclude self + .withoutName("use isEmpty() instead of isEqualTo(empty)") + .assertFalse { functionDeclaration -> + functionDeclaration.text.contains("isEqualTo(empty") + } + } }