From 8afc103c1d46e57c211ff1e153d7a0cf4aeb22e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jorge=20Mart=C3=ADn?= Date: Thu, 17 Aug 2023 16:01:59 +0200 Subject: [PATCH 1/2] Fix snackbar padding --- .../element/android/libraries/designsystem/utils/Snackbar.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/Snackbar.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/Snackbar.kt index 4513a90914..c689d7e547 100644 --- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/Snackbar.kt +++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/Snackbar.kt @@ -17,6 +17,7 @@ package io.element.android.libraries.designsystem.utils import androidx.annotation.StringRes +import androidx.compose.foundation.layout.padding import androidx.compose.material.icons.Icons import androidx.compose.material.icons.filled.Close import androidx.compose.material3.SnackbarDuration @@ -29,6 +30,7 @@ import androidx.compose.runtime.compositionLocalOf import androidx.compose.runtime.remember import androidx.compose.ui.Modifier import androidx.compose.ui.res.stringResource +import androidx.compose.ui.unit.dp import io.element.android.libraries.designsystem.components.button.ButtonVisuals import io.element.android.libraries.designsystem.theme.components.IconSource import io.element.android.libraries.designsystem.theme.components.Snackbar @@ -75,6 +77,7 @@ fun SnackbarDispatcher.collectSnackbarMessageAsState(): State fun SnackbarHost(hostState: SnackbarHostState, modifier: Modifier = Modifier) { androidx.compose.material3.SnackbarHost(hostState, modifier) { data -> Snackbar( + modifier = Modifier.padding(12.dp), // Add default padding message = data.visuals.message, action = data.visuals.actionLabel?.let { ButtonVisuals.Text(it, data::performAction) }, dismissAction = if (data.visuals.withDismissAction) { From 1e74cf298867f08d1cb03d3aa686e318e50ac13f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jorge=20Mart=C3=ADn?= Date: Thu, 17 Aug 2023 16:28:35 +0200 Subject: [PATCH 2/2] Try to fix showkase metadata code generation --- build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle.kts b/build.gradle.kts index 3dfef189e2..bb750d6055 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -352,7 +352,7 @@ subprojects { doLast { fileTree(buildDir).apply { include("**/*ShowkaseExtension*.kt") }.files.forEach { file -> ReplaceRegExp().apply { - setMatch("public fun Showkase.getMetadata") + setMatch("^public fun Showkase.getMetadata") setReplace("@Suppress(\"DEPRECATION\") public fun Showkase.getMetadata") setFlags("g") setByLine(true)