From 937519639df02b903a6d23d66a54ebd235ff6ba0 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 23 Oct 2025 09:59:24 +0200
Subject: [PATCH] Add missing test.

---
 .../libraries/androidutils/json/JsonProvider.kt    |  2 +-
 .../SyncNotificationWorkManagerRequestTest.kt      | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/json/JsonProvider.kt b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/json/JsonProvider.kt
index 08226060db..2e91cd6784 100644
--- a/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/json/JsonProvider.kt
+++ b/libraries/androidutils/src/main/kotlin/io/element/android/libraries/androidutils/json/JsonProvider.kt
@@ -17,7 +17,7 @@ import kotlinx.serialization.json.Json
 /**
  * Provides a Json instance configured to ignore unknown keys.
  */
-interface JsonProvider : Provider<Json>
+fun interface JsonProvider : Provider<Json>
 
 @ContributesBinding(AppScope::class)
 @SingleIn(AppScope::class)
diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt
index fcefd8ab8b..ebbe4eb865 100644
--- a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt
+++ b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/workmanager/SyncNotificationWorkManagerRequestTest.kt
@@ -49,14 +49,24 @@ class SyncNotificationWorkManagerRequestTest {
         assertThat(result.isFailure).isTrue()
     }
 
-    // TODO add test for invalid serialization (how?)
+    @Test
+    fun `build - invalid serialization`() = runTest {
+        val request = createSyncNotificationWorkManagerRequest(
+            sessionId = A_SESSION_ID,
+            notificationEventRequests = listOf(aNotificationEventRequest()),
+            workerDataConverter = WorkerDataConverter({ error("error during serialization") })
+        )
+        val result = request.build()
+        assertThat(result.isFailure).isTrue()
+    }
 }
 
 private fun createSyncNotificationWorkManagerRequest(
     sessionId: SessionId,
     notificationEventRequests: List<NotificationEventRequest>,
+    workerDataConverter: WorkerDataConverter = WorkerDataConverter(DefaultJsonProvider())
 ) = SyncNotificationWorkManagerRequest(
     sessionId = sessionId,
     notificationEventRequests = notificationEventRequests,
-    workerDataConverter = WorkerDataConverter(DefaultJsonProvider()),
+    workerDataConverter = workerDataConverter,
 )