diff --git a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/AnnouncementPresenter.kt b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/AnnouncementPresenter.kt index 9600dd7229..d7e63e6ebe 100644 --- a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/AnnouncementPresenter.kt +++ b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/AnnouncementPresenter.kt @@ -24,7 +24,7 @@ class AnnouncementPresenter( @Composable override fun present(): AnnouncementState { val showSpaceAnnouncement by remember { - announcementStore.announcementStateFlow(Announcement.Space).map { + announcementStore.announcementStatusFlow(Announcement.Space).map { it == AnnouncementStore.AnnouncementStatus.Show } }.collectAsState(false) diff --git a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementService.kt b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementService.kt index a092025bdc..e373e46f5a 100644 --- a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementService.kt +++ b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementService.kt @@ -49,8 +49,8 @@ class DefaultAnnouncementService( override fun announcementsToShowFlow(): Flow> { return combine( - announcementStore.announcementStateFlow(Announcement.Space), - announcementStore.announcementStateFlow(Announcement.NewNotificationSound), + announcementStore.announcementStatusFlow(Announcement.Space), + announcementStore.announcementStatusFlow(Announcement.NewNotificationSound), ) { spaceAnnouncementStatus, newNotificationSoundStatus -> buildList { if (spaceAnnouncementStatus == AnnouncementStore.AnnouncementStatus.Show) { @@ -64,7 +64,7 @@ class DefaultAnnouncementService( } private suspend fun showSpaceAnnouncement() { - val currentValue = announcementStore.announcementStateFlow(Announcement.Space).first() + val currentValue = announcementStore.announcementStatusFlow(Announcement.Space).first() if (currentValue == AnnouncementStore.AnnouncementStatus.NeverShown) { announcementStore.setAnnouncementStatus(Announcement.Space, AnnouncementStore.AnnouncementStatus.Show) } diff --git a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/AnnouncementStore.kt b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/AnnouncementStore.kt index d69029d27a..6742adf468 100644 --- a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/AnnouncementStore.kt +++ b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/AnnouncementStore.kt @@ -16,7 +16,7 @@ interface AnnouncementStore { status: AnnouncementStatus, ) - fun announcementStateFlow( + fun announcementStatusFlow( announcement: Announcement, ): Flow diff --git a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/DefaultAnnouncementStore.kt b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/DefaultAnnouncementStore.kt index bb711bdbf6..452d18f6cf 100644 --- a/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/DefaultAnnouncementStore.kt +++ b/features/announcement/impl/src/main/kotlin/io/element/android/features/announcement/impl/store/DefaultAnnouncementStore.kt @@ -34,7 +34,7 @@ class DefaultAnnouncementStore( } } - override fun announcementStateFlow(announcement: Announcement): Flow { + override fun announcementStatusFlow(announcement: Announcement): Flow { val key = announcement.toKey() // For NewNotificationSound, a migration will set it to Show on application upgrade (see AppMigration08) val defaultStatus = when (announcement) { diff --git a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementServiceTest.kt b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementServiceTest.kt index 9a7abc9ffc..6188894a44 100644 --- a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementServiceTest.kt +++ b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/DefaultAnnouncementServiceTest.kt @@ -25,14 +25,14 @@ class DefaultAnnouncementServiceTest { val sut = createDefaultAnnouncementService( announcementStore = announcementStore, ) - assertThat(announcementStore.announcementStateFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.NeverShown) + assertThat(announcementStore.announcementStatusFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.NeverShown) sut.showAnnouncement(Announcement.Space) - assertThat(announcementStore.announcementStateFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Show) + assertThat(announcementStore.announcementStatusFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Show) // Simulate user close the announcement sut.onAnnouncementDismissed(Announcement.Space) // Entering again the space tab should not change the value sut.showAnnouncement(Announcement.Space) - assertThat(announcementStore.announcementStateFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Shown) + assertThat(announcementStore.announcementStatusFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Shown) } private fun createDefaultAnnouncementService( diff --git a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/spaces/SpaceAnnouncementPresenterTest.kt b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/spaces/SpaceAnnouncementPresenterTest.kt index 0a85dd8a42..c8dd199018 100644 --- a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/spaces/SpaceAnnouncementPresenterTest.kt +++ b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/spaces/SpaceAnnouncementPresenterTest.kt @@ -24,10 +24,10 @@ class SpaceAnnouncementPresenterTest { announcementStore = store, ) presenter.test { - assertThat(store.announcementStateFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.NeverShown) + assertThat(store.announcementStatusFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.NeverShown) val state = awaitItem() state.eventSink(SpaceAnnouncementEvents.Continue) - assertThat(store.announcementStateFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Shown) + assertThat(store.announcementStatusFlow(Announcement.Space).first()).isEqualTo(AnnouncementStore.AnnouncementStatus.Shown) } } } diff --git a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/store/InMemoryAnnouncementStore.kt b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/store/InMemoryAnnouncementStore.kt index c119417bd5..6dfcac6f39 100644 --- a/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/store/InMemoryAnnouncementStore.kt +++ b/features/announcement/impl/src/test/kotlin/io/element/android/features/announcement/impl/store/InMemoryAnnouncementStore.kt @@ -26,7 +26,7 @@ class InMemoryAnnouncementStore( } } - override fun announcementStateFlow(announcement: Announcement): Flow { + override fun announcementStatusFlow(announcement: Announcement): Flow { return when (announcement) { Announcement.Space -> spaceAnnouncement.asStateFlow() Announcement.NewNotificationSound -> newNotificationSoundAnnouncement.asStateFlow()