From 262084a38b25123e2f1901e8c88f42f0e746c5ed Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 25 Jul 2023 17:23:22 +0200 Subject: [PATCH 1/5] fix typo --- .maestro/tests/roomList/createAndDeleteRoom.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.maestro/tests/roomList/createAndDeleteRoom.yaml b/.maestro/tests/roomList/createAndDeleteRoom.yaml index b2b7c1da0b..5ec7060679 100644 --- a/.maestro/tests/roomList/createAndDeleteRoom.yaml +++ b/.maestro/tests/roomList/createAndDeleteRoom.yaml @@ -17,7 +17,7 @@ appId: ${APP_ID} - takeScreenshot: build/maestro/320-createAndDeleteRoom - tapOn: "aRoomName" - tapOn: "Invite people" -# assert there's 1 memeber and 1 invitee +# assert there's 1 member and 1 invitee - tapOn: "Search for someone" - inputText: ${INVITEE2_MXID} - tapOn: @@ -27,7 +27,7 @@ appId: ${APP_ID} - tapOn: "Back" - tapOn: "aRoomName" - tapOn: "People" -# assert there's 1 memeber and 2 invitees +# assert there's 1 member and 2 invitees - tapOn: "Back" - tapOn: "Leave room" - tapOn: "Leave" From 07689092a97176cfa6eaed29b64c82f40caeb071 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 17 Aug 2023 11:37:12 +0200 Subject: [PATCH 2/5] Maestro test: change server to test server which does not support sliding sync. (#1066) --- .maestro/tests/account/changeServer.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.maestro/tests/account/changeServer.yaml b/.maestro/tests/account/changeServer.yaml index df4b12f253..3e103b0b3b 100644 --- a/.maestro/tests/account/changeServer.yaml +++ b/.maestro/tests/account/changeServer.yaml @@ -9,9 +9,10 @@ appId: ${APP_ID} - tapOn: "Other" - tapOn: id: "change_server-server" -- inputText: "element" +# Test server that does not support sliding sync. +- inputText: "gnuradio" - hideKeyboard -- tapOn: "element.io" +- tapOn: "gnuradio.org" - tapOn: "Cancel" - back - back From 80df78bd7c911492e9f287587a8271cbecedfe40 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 17 Aug 2023 11:39:58 +0200 Subject: [PATCH 3/5] Maestro test: add assertion for server with no sliding sync error. --- .maestro/tests/account/changeServer.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.maestro/tests/account/changeServer.yaml b/.maestro/tests/account/changeServer.yaml index 3e103b0b3b..e503589f5c 100644 --- a/.maestro/tests/account/changeServer.yaml +++ b/.maestro/tests/account/changeServer.yaml @@ -13,6 +13,9 @@ appId: ${APP_ID} - inputText: "gnuradio" - hideKeyboard - tapOn: "gnuradio.org" +- extendedWaitUntil: + visible: "This server currently doesn’t support sliding sync." + timeout: 10_000 - tapOn: "Cancel" - back - back From 23e7245981466eacd6f16ecea107323b06273c93 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 19 Jan 2023 15:42:22 +0100 Subject: [PATCH 4/5] Add check for all env variables (fail fast). --- .maestro/allTests.yaml | 2 ++ .maestro/scripts/checkEnv.js | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 .maestro/scripts/checkEnv.js diff --git a/.maestro/allTests.yaml b/.maestro/allTests.yaml index 8283e9fed5..cd3ca342e2 100644 --- a/.maestro/allTests.yaml +++ b/.maestro/allTests.yaml @@ -1,5 +1,7 @@ appId: ${APP_ID} --- +## Check that all env variables required in the whole test suite are declared (to fail faster) +- runScript: ./scripts/checkEnv.js - runFlow: tests/init.yaml - runFlow: tests/account/login.yaml - runFlow: tests/settings/settings.yaml diff --git a/.maestro/scripts/checkEnv.js b/.maestro/scripts/checkEnv.js new file mode 100644 index 0000000000..74b4b56956 --- /dev/null +++ b/.maestro/scripts/checkEnv.js @@ -0,0 +1,9 @@ +// This array contains all the required environment variable. When adding a variable, add it here also. +// If a variable is missing, an error will occur. + +if (APP_ID == null) throw "Fatal: missing env variable APP_ID" +if (USERNAME == null) throw "Fatal: missing env variable USERNAME" +if (PASSWORD == null) throw "Fatal: missing env variable PASSWORD" +if (ROOM_NAME == null) throw "Fatal: missing env variable ROOM_NAME" +if (INVITEE1_MXID == null) throw "Fatal: missing env variable INVITEE1_MXID" +if (INVITEE2_MXID == null) throw "Fatal: missing env variable INVITEE2_MXID" From 4843e9819f7073e9192854c73395e0683c6ab155 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Thu, 17 Aug 2023 14:38:49 +0200 Subject: [PATCH 5/5] Maestro test: fix test failing locally --- .maestro/tests/roomList/searchRoomList.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.maestro/tests/roomList/searchRoomList.yaml b/.maestro/tests/roomList/searchRoomList.yaml index 5125109197..6c31acd4db 100644 --- a/.maestro/tests/roomList/searchRoomList.yaml +++ b/.maestro/tests/roomList/searchRoomList.yaml @@ -7,6 +7,7 @@ appId: ${APP_ID} - tapOn: ${ROOM_NAME} # Back from timeline - back +- assertVisible: "MyR" # Close keyboard - hideKeyboard # Back from search