From 79c5bd25c34db49ada992adb5094deb31c81139e Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Wed, 30 Aug 2023 10:24:57 +0200 Subject: [PATCH] Compact the code and reorder vals for code clarity --- .../api/preferences/AnalyticsPreferencesView.kt | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt b/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt index 468babcc6f..b943199ba5 100644 --- a/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt +++ b/features/analytics/api/src/main/kotlin/io/element/android/features/analytics/api/preferences/AnalyticsPreferencesView.kt @@ -42,18 +42,16 @@ fun AnalyticsPreferencesView( state.eventSink(AnalyticsOptInEvents.EnableAnalytics(isEnabled = isEnabled)) } + val supportingText = stringResource( + id = CommonStrings.screen_analytics_settings_help_us_improve, + state.applicationName + ) val linkText = buildAnnotatedStringWithStyledPart( CommonStrings.screen_analytics_settings_read_terms, CommonStrings.screen_analytics_settings_read_terms_content_link, tagAndLink = LINK_TAG to state.policyUrl, ) - val supportingText = stringResource( - id = CommonStrings.screen_analytics_settings_help_us_improve, - state.applicationName - ) - Column(modifier) { - ListItem( headlineContent = { Text(stringResource(id = CommonStrings.screen_analytics_settings_share_data)) @@ -69,10 +67,8 @@ fun AnalyticsPreferencesView( onEnabledChanged(!state.isEnabled) } ) - ListSupportingText(annotatedString = linkText) } - } @Preview