From 7190ffa3e093e70226af392898b38bd6657006dd Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 28 Sep 2023 17:09:08 +0200
Subject: [PATCH] Add strings for advanced settings into Localazy.

---
 .../impl/advanced/AdvancedSettingsView.kt            | 12 +++++-------
 .../impl/src/main/res/values/localazy.xml            |  3 +++
 tools/localazy/config.json                           |  1 +
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt
index ee343a26d6..6ab46402bc 100644
--- a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt
+++ b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/advanced/AdvancedSettingsView.kt
@@ -20,10 +20,11 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.PreviewParameter
+import io.element.android.features.preferences.impl.R
 import io.element.android.libraries.designsystem.components.preferences.PreferenceSwitch
 import io.element.android.libraries.designsystem.components.preferences.PreferenceView
-import io.element.android.libraries.designsystem.preview.PreviewsDayNight
 import io.element.android.libraries.designsystem.preview.ElementPreview
+import io.element.android.libraries.designsystem.preview.PreviewsDayNight
 import io.element.android.libraries.ui.strings.CommonStrings
 
 @Composable
@@ -39,16 +40,13 @@ fun AdvancedSettingsView(
     ) {
         PreferenceSwitch(
             title = stringResource(id = CommonStrings.common_rich_text_editor),
-            // TODO i18n
-            subtitle = "Disable the rich text editor to type Markdown manually",
+            subtitle = stringResource(id = R.string.screen_advanced_settings_rich_text_editor_description),
             isChecked = state.isRichTextEditorEnabled,
             onCheckedChange = { state.eventSink(AdvancedSettingsEvents.SetRichTextEditorEnabled(it)) },
         )
         PreferenceSwitch(
-            // TODO i18n
-            title = "Developer mode",
-            // TODO i18n
-            subtitle = "The developer mode activates hidden features. For developers only!",
+            title = stringResource(id = R.string.screen_advanced_settings_developer_mode),
+            subtitle = stringResource(id = R.string.screen_advanced_settings_developer_mode_description),
             isChecked = state.isDeveloperModeEnabled,
             onCheckedChange = { state.eventSink(AdvancedSettingsEvents.SetDeveloperModeEnabled(it)) },
         )
diff --git a/features/preferences/impl/src/main/res/values/localazy.xml b/features/preferences/impl/src/main/res/values/localazy.xml
index f01ae2b5e1..d4f7c7ef11 100644
--- a/features/preferences/impl/src/main/res/values/localazy.xml
+++ b/features/preferences/impl/src/main/res/values/localazy.xml
@@ -1,5 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
+  <string name="screen_advanced_settings_developer_mode">"Developer mode"</string>
+  <string name="screen_advanced_settings_developer_mode_description">"By enabling you get access to features and functions for developers."</string>
+  <string name="screen_advanced_settings_rich_text_editor_description">"Disable the rich text editor to type Markdown manually."</string>
   <string name="screen_edit_profile_display_name">"Display name"</string>
   <string name="screen_edit_profile_display_name_placeholder">"Your display name"</string>
   <string name="screen_edit_profile_error">"An unknown error was encountered and the information couldn\'t be changed."</string>
diff --git a/tools/localazy/config.json b/tools/localazy/config.json
index 0d410fc9c4..3842198da6 100644
--- a/tools/localazy/config.json
+++ b/tools/localazy/config.json
@@ -138,6 +138,7 @@
     {
       "name": ":features:preferences:impl",
       "includeRegex": [
+        "screen_advanced_settings_.*",
         "screen_edit_profile_.*"
       ]
     },