From 6e722a299820ed12e8e939a5dc70e218f765d3d3 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Fri, 17 Oct 2025 14:52:06 +0200 Subject: [PATCH] Fix typo. --- .../libraries/featureflag/api/FeatureFlagService.kt | 4 ++-- .../featureflag/impl/DefaultFeatureFlagService.kt | 4 ++-- .../featureflag/impl/DefaultFeatureFlagServiceTest.kt | 8 ++++---- .../libraries/featureflag/test/FakeFeatureFlagService.kt | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt b/libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt index c6319cc03b..2623faa3ab 100644 --- a/libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt +++ b/libraries/featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlagService.kt @@ -36,11 +36,11 @@ interface FeatureFlagService { /** * @return the list of available features that can be toggled. - * @param includeFinishFeatures whether to include finished features, default is false + * @param includeFinishedFeatures whether to include finished features, default is false * @param isInLabs whether the user is in labs (to include lab features), default is false */ fun getAvailableFeatures( - includeFinishFeatures: Boolean = false, + includeFinishedFeatures: Boolean = false, isInLabs: Boolean = false, ): List } diff --git a/libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt b/libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt index 0e7a389250..cecd0ca0a8 100644 --- a/libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt +++ b/libraries/featureflag/impl/src/main/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagService.kt @@ -41,11 +41,11 @@ class DefaultFeatureFlagService( } override fun getAvailableFeatures( - includeFinishFeatures: Boolean, + includeFinishedFeatures: Boolean, isInLabs: Boolean, ): List { return featuresProvider.provide().filter { flag -> - (includeFinishFeatures || !flag.isFinished) && + (includeFinishedFeatures || !flag.isFinished) && flag.isInLabs == isInLabs } } diff --git a/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt b/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt index c1f33333c4..438dbe1ecc 100644 --- a/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt +++ b/libraries/featureflag/impl/src/test/kotlin/io/element/android/libraries/featureflag/impl/DefaultFeatureFlagServiceTest.kt @@ -133,25 +133,25 @@ class DefaultFeatureFlagServiceTest { ) assertThat( featureFlagService.getAvailableFeatures( - includeFinishFeatures = false, + includeFinishedFeatures = false, isInLabs = true, ) ).containsExactly(anUnfinishedLabFeature) assertThat( featureFlagService.getAvailableFeatures( - includeFinishFeatures = true, + includeFinishedFeatures = true, isInLabs = true, ) ).containsExactly(aFinishedLabFeature, anUnfinishedLabFeature) assertThat( featureFlagService.getAvailableFeatures( - includeFinishFeatures = false, + includeFinishedFeatures = false, isInLabs = false, ) ).containsExactly(anUnfinishedDevFeature) assertThat( featureFlagService.getAvailableFeatures( - includeFinishFeatures = true, + includeFinishedFeatures = true, isInLabs = false, ) ).containsExactly(aFinishedDevFeature, anUnfinishedDevFeature) diff --git a/libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt b/libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt index 60bd401cef..456936e501 100644 --- a/libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt +++ b/libraries/featureflag/test/src/main/java/io/element/android/libraries/featureflag/test/FakeFeatureFlagService.kt @@ -34,9 +34,9 @@ class FakeFeatureFlagService( } override fun getAvailableFeatures( - includeFinishFeatures: Boolean, + includeFinishedFeatures: Boolean, isInLabs: Boolean, ): List { - return getAvailableFeaturesResult(includeFinishFeatures, isInLabs) + return getAvailableFeaturesResult(includeFinishedFeatures, isInLabs) } }