From 669db8c0fa1fbb945dcb656172299fd8aaa3e646 Mon Sep 17 00:00:00 2001 From: ganfra Date: Mon, 9 Dec 2024 19:58:54 +0100 Subject: [PATCH] fix(dm) : remove duplicate LaunchedEffect --- .../impl/members/details/RoomMemberDetailsNode.kt | 8 -------- .../features/userprofile/impl/root/UserProfileNode.kt | 8 -------- 2 files changed, 16 deletions(-) diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/details/RoomMemberDetailsNode.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/details/RoomMemberDetailsNode.kt index 06748b0999..60aa00150b 100644 --- a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/details/RoomMemberDetailsNode.kt +++ b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/details/RoomMemberDetailsNode.kt @@ -8,7 +8,6 @@ package io.element.android.features.roomdetails.impl.members.details import androidx.compose.runtime.Composable -import androidx.compose.runtime.LaunchedEffect import androidx.compose.ui.Modifier import androidx.compose.ui.platform.LocalContext import com.bumble.appyx.core.lifecycle.subscribe @@ -21,7 +20,6 @@ import im.vector.app.features.analytics.plan.MobileScreen import io.element.android.anvilannotations.ContributesNode import io.element.android.features.userprofile.shared.UserProfileNodeHelper import io.element.android.features.userprofile.shared.UserProfileView -import io.element.android.libraries.architecture.AsyncAction import io.element.android.libraries.architecture.NodeInputs import io.element.android.libraries.architecture.inputs import io.element.android.libraries.di.RoomScope @@ -73,12 +71,6 @@ class RoomMemberDetailsNode @AssistedInject constructor( val state = presenter.present() - LaunchedEffect(state.startDmActionState) { - val result = state.startDmActionState - if (result is AsyncAction.Success) { - onStartDM(result.data) - } - } UserProfileView( state = state, modifier = modifier, diff --git a/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/root/UserProfileNode.kt b/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/root/UserProfileNode.kt index e3ce329b09..da86349adb 100644 --- a/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/root/UserProfileNode.kt +++ b/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/root/UserProfileNode.kt @@ -8,7 +8,6 @@ package io.element.android.features.userprofile.impl.root import androidx.compose.runtime.Composable -import androidx.compose.runtime.LaunchedEffect import androidx.compose.ui.Modifier import androidx.compose.ui.platform.LocalContext import com.bumble.appyx.core.lifecycle.subscribe @@ -21,7 +20,6 @@ import im.vector.app.features.analytics.plan.MobileScreen import io.element.android.anvilannotations.ContributesNode import io.element.android.features.userprofile.shared.UserProfileNodeHelper import io.element.android.features.userprofile.shared.UserProfileView -import io.element.android.libraries.architecture.AsyncAction import io.element.android.libraries.architecture.NodeInputs import io.element.android.libraries.architecture.inputs import io.element.android.libraries.di.SessionScope @@ -69,12 +67,6 @@ class UserProfileNode @AssistedInject constructor( val state = presenter.present() - LaunchedEffect(state.startDmActionState) { - val result = state.startDmActionState - if (result is AsyncAction.Success) { - onStartDM(result.data) - } - } UserProfileView( state = state, modifier = modifier,