From 653f7944758a9a264f8a8565130e1257ac0fb308 Mon Sep 17 00:00:00 2001
From: ganfra <francoisg@element.io>
Date: Wed, 3 Dec 2025 15:08:43 +0100
Subject: [PATCH] change(room details edit): adjust the ui

---
 .../impl/RoomDetailsEditStateProvider.kt           |  2 +-
 .../roomdetailsedit/impl/RoomDetailsEditView.kt    | 14 ++++++++------
 .../ui-strings/src/main/res/values/localazy.xml    |  2 ++
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditStateProvider.kt b/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditStateProvider.kt
index d1f13d252c..cecdcfa9d5 100644
--- a/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditStateProvider.kt
+++ b/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditStateProvider.kt
@@ -23,7 +23,7 @@ open class RoomDetailsEditStateProvider : PreviewParameterProvider<RoomDetailsEd
             aRoomDetailsEditState(roomTopic = ""),
             aRoomDetailsEditState(roomRawName = ""),
             aRoomDetailsEditState(roomAvatarUrl = "example://uri"),
-            aRoomDetailsEditState(roomAvatarUrl = "example://uri", isSpace = true),
+            aRoomDetailsEditState(roomAvatarUrl = "example://uri", isSpace = true, roomTopic = ""),
             aRoomDetailsEditState(canChangeName = true, canChangeTopic = false, canChangeAvatar = true, saveButtonEnabled = false),
             aRoomDetailsEditState(canChangeName = false, canChangeTopic = true, canChangeAvatar = false, saveButtonEnabled = false),
             aRoomDetailsEditState(saveAction = AsyncAction.Loading),
diff --git a/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditView.kt b/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditView.kt
index 22795c98d3..55a6d038dd 100644
--- a/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditView.kt
+++ b/features/roomdetailsedit/impl/src/main/kotlin/io/element/android/features/roomdetailsedit/impl/RoomDetailsEditView.kt
@@ -16,7 +16,6 @@ import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.imePadding
-import androidx.compose.foundation.layout.navigationBarsPadding
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.text.KeyboardOptions
@@ -96,7 +95,6 @@ fun RoomDetailsEditView(
             modifier = Modifier
                 .padding(padding)
                 .padding(horizontal = 16.dp)
-                .navigationBarsPadding()
                 .imePadding()
                 .verticalScroll(rememberScrollState())
         ) {
@@ -115,10 +113,10 @@ fun RoomDetailsEditView(
                 onAvatarClick = ::onAvatarClick,
                 modifier = Modifier.fillMaxWidth(),
             )
-            Spacer(modifier = Modifier.height(60.dp))
+            Spacer(modifier = Modifier.height(32.dp))
 
             TextField(
-                label = stringResource(id = CommonStrings.common_room_name),
+                label = stringResource(id = CommonStrings.common_name),
                 value = state.roomRawName,
                 placeholder = stringResource(CommonStrings.common_room_name_placeholder),
                 singleLine = true,
@@ -126,12 +124,16 @@ fun RoomDetailsEditView(
                 onValueChange = { state.eventSink(RoomDetailsEditEvents.UpdateRoomName(it)) },
             )
 
-            Spacer(modifier = Modifier.height(28.dp))
+            Spacer(modifier = Modifier.height(32.dp))
 
             TextField(
                 label = stringResource(CommonStrings.common_topic),
                 value = state.roomTopic,
-                placeholder = stringResource(CommonStrings.common_topic_placeholder),
+                placeholder = if (state.isSpace) {
+                    stringResource(CommonStrings.common_space_topic_placeholder)
+                } else {
+                    stringResource(CommonStrings.common_topic_placeholder)
+                },
                 maxLines = 10,
                 readOnly = !state.canChangeTopic,
                 onValueChange = { state.eventSink(RoomDetailsEditEvents.UpdateRoomTopic(it)) },
diff --git a/libraries/ui-strings/src/main/res/values/localazy.xml b/libraries/ui-strings/src/main/res/values/localazy.xml
index dcd3cdd6e2..8be01eb439 100644
--- a/libraries/ui-strings/src/main/res/values/localazy.xml
+++ b/libraries/ui-strings/src/main/res/values/localazy.xml
@@ -251,6 +251,7 @@ Reason: %1$s."</string>
   <string name="common_message_removed">"Message removed"</string>
   <string name="common_modern">"Modern"</string>
   <string name="common_mute">"Mute"</string>
+  <string name="common_name">"Name"</string>
   <string name="common_name_and_id">"%1$s (%2$s)"</string>
   <string name="common_no_results">"No results"</string>
   <string name="common_no_room_name">"No room name"</string>
@@ -325,6 +326,7 @@ Reason: %1$s."</string>
   <string name="common_something_went_wrong">"Something went wrong"</string>
   <string name="common_something_went_wrong_message">"We encountered an issue. Please try again."</string>
   <string name="common_space">"Space"</string>
+  <string name="common_space_topic_placeholder">"What is this space about?"</string>
   <plurals name="common_spaces">
     <item quantity="one">"%1$d Space"</item>
     <item quantity="other">"%1$d Spaces"</item>