From 641028c0821ce3ecbbe16a6449bd83b84cefe0d4 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 27 Jun 2023 12:45:15 +0200 Subject: [PATCH] Use a determinate progress indicator to improve the preview rendering --- .../components/CircularProgressIndicator.kt | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/CircularProgressIndicator.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/CircularProgressIndicator.kt index 015f381678..392e267c77 100644 --- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/CircularProgressIndicator.kt +++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/components/CircularProgressIndicator.kt @@ -22,6 +22,7 @@ import androidx.compose.material3.ProgressIndicatorDefaults import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.graphics.Color +import androidx.compose.ui.platform.LocalInspectionMode import androidx.compose.ui.tooling.preview.Preview import androidx.compose.ui.unit.Dp import androidx.compose.ui.unit.dp @@ -49,11 +50,21 @@ fun CircularProgressIndicator( color: Color = ProgressIndicatorDefaults.circularColor, strokeWidth: Dp = ProgressIndicatorDefaults.CircularStrokeWidth, ) { - androidx.compose.material3.CircularProgressIndicator( - modifier = modifier, - color = color, - strokeWidth = strokeWidth, - ) + if (LocalInspectionMode.current) { + // Use a determinate progress indicator to improve the preview rendering + androidx.compose.material3.CircularProgressIndicator( + modifier = modifier, + progress = 0.75F, + color = color, + strokeWidth = strokeWidth, + ) + } else { + androidx.compose.material3.CircularProgressIndicator( + modifier = modifier, + color = color, + strokeWidth = strokeWidth, + ) + } } @Preview(group = PreviewGroup.Progress) @@ -68,7 +79,7 @@ private fun ContentToPreview() { ) // Fixed progress CircularProgressIndicator( - progress = 0.75F + progress = 0.90F ) } }