From 613cd4f863189101767fc4102f6a140fd0b35ba6 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Wed, 26 Jul 2023 11:50:58 +0200
Subject: [PATCH] Enable detekt rules `UseDataClass` and fix existing issues.

---
 .../android/libraries/designsystem/utils/LogCompositions.kt | 6 ++++--
 tools/detekt/detekt.yml                                     | 3 +++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/LogCompositions.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/LogCompositions.kt
index dcbef866fe..2618a5de82 100644
--- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/LogCompositions.kt
+++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/utils/LogCompositions.kt
@@ -28,10 +28,12 @@ import timber.log.Timber
 @Composable
 fun LogCompositions(tag: String, msg: String) {
     if (BuildConfig.DEBUG) {
-        val ref = remember { Ref(0) }
+        val ref = remember { Ref() }
         SideEffect { ref.value++ }
         Timber.tag(tag).d("Compositions: $msg ${ref.value}")
     }
 }
 
-class Ref(var value: Int)
+private class Ref {
+    var value: Int = 0
+}
diff --git a/tools/detekt/detekt.yml b/tools/detekt/detekt.yml
index 0675583bd8..fbecf65073 100644
--- a/tools/detekt/detekt.yml
+++ b/tools/detekt/detekt.yml
@@ -60,6 +60,9 @@ style:
     active: true
     acceptableLength: 4
     allowNonStandardGrouping: false
+  UseDataClass:
+    active: true
+    allowVars: false
 
 coroutines:
   GlobalCoroutineUsage: