From 57ced5423a18f02aa7f42071f86ec762fbfe2b5b Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Fri, 8 Nov 2024 16:20:07 +0100
Subject: [PATCH] incomingCallTimedOut() does not need to be exposed in the
 interface.

---
 .../features/call/impl/utils/ActiveCallManager.kt    | 12 ++++++------
 .../features/call/utils/FakeActiveCallManager.kt     |  5 -----
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt
index d774a5133c..2b8aacc1b5 100644
--- a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt
+++ b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt
@@ -8,6 +8,7 @@
 package io.element.android.features.call.impl.utils
 
 import android.annotation.SuppressLint
+import androidx.annotation.VisibleForTesting
 import androidx.core.app.NotificationManagerCompat
 import com.squareup.anvil.annotations.ContributesBinding
 import io.element.android.appconfig.ElementCallConfig
@@ -56,11 +57,6 @@ interface ActiveCallManager {
      */
     fun registerIncomingCall(notificationData: CallNotificationData)
 
-    /**
-     * Called when the incoming call timed out. It will remove the active call and remove any associated UI, adding a 'missed call' notification.
-     */
-    fun incomingCallTimedOut()
-
     /**
      * Called when the active call has been hung up. It will remove any existing UI and the active call.
      * @param callType The type of call that the user hung up, either an external url one or a room one.
@@ -117,7 +113,11 @@ class DefaultActiveCallManager @Inject constructor(
         }
     }
 
-    override fun incomingCallTimedOut() {
+    /**
+     * Called when the incoming call timed out. It will remove the active call and remove any associated UI, adding a 'missed call' notification.
+     */
+    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+    fun incomingCallTimedOut() {
         val previousActiveCall = activeCall.value ?: return
         val notificationData = (previousActiveCall.callState as? CallState.Ringing)?.notificationData ?: return
         activeCall.value = null
diff --git a/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/FakeActiveCallManager.kt b/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/FakeActiveCallManager.kt
index 8ec385d861..9554a46dae 100644
--- a/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/FakeActiveCallManager.kt
+++ b/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/FakeActiveCallManager.kt
@@ -15,7 +15,6 @@ import kotlinx.coroutines.flow.MutableStateFlow
 
 class FakeActiveCallManager(
     var registerIncomingCallResult: (CallNotificationData) -> Unit = {},
-    var incomingCallTimedOutResult: () -> Unit = {},
     var hungUpCallResult: (CallType) -> Unit = {},
     var joinedCallResult: (CallType) -> Unit = {},
 ) : ActiveCallManager {
@@ -25,10 +24,6 @@ class FakeActiveCallManager(
         registerIncomingCallResult(notificationData)
     }
 
-    override fun incomingCallTimedOut() {
-        incomingCallTimedOutResult()
-    }
-
     override fun hungUpCall(callType: CallType) {
         hungUpCallResult(callType)
     }