From 542de5a48731a49b652e517312ee9feb57f2e496 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Wed, 22 Nov 2023 14:55:14 +0100
Subject: [PATCH] Remove default value for lambda. We enforce a value to be
 provided and it's better for code code coverage.

---
 .../RoomNotificationSettingsView.kt                    | 10 +++++++---
 .../UserDefinedRoomNotificationSettingsView.kt         |  7 +++++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsView.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsView.kt
index cdb46a2fcc..dd7d309569 100644
--- a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsView.kt
+++ b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/RoomNotificationSettingsView.kt
@@ -51,9 +51,9 @@ import io.element.android.libraries.ui.strings.CommonStrings
 @Composable
 fun RoomNotificationSettingsView(
     state: RoomNotificationSettingsState,
+    onShowGlobalNotifications: () -> Unit,
+    onBackPressed: () -> Unit,
     modifier: Modifier = Modifier,
-    onShowGlobalNotifications: () -> Unit = {},
-    onBackPressed: () -> Unit = {},
 ) {
     if (state.showUserDefinedSettingStyle) {
         UserDefinedRoomNotificationSettingsView(
@@ -193,5 +193,9 @@ private fun RoomNotificationSettingsTopBar(
 internal fun RoomNotificationSettingsPreview(
     @PreviewParameter(RoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState
 ) = ElementPreview {
-    RoomNotificationSettingsView(state)
+    RoomNotificationSettingsView(
+        state = state,
+        onShowGlobalNotifications = {},
+        onBackPressed = {},
+    )
 }
diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/UserDefinedRoomNotificationSettingsView.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/UserDefinedRoomNotificationSettingsView.kt
index e304ee2cfa..6b67e1bf87 100644
--- a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/UserDefinedRoomNotificationSettingsView.kt
+++ b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/notificationsettings/UserDefinedRoomNotificationSettingsView.kt
@@ -42,8 +42,8 @@ import io.element.android.libraries.designsystem.theme.components.TopAppBar
 @Composable
 fun UserDefinedRoomNotificationSettingsView(
     state: RoomNotificationSettingsState,
+    onBackPressed: () -> Unit,
     modifier: Modifier = Modifier,
-    onBackPressed: () -> Unit = {},
 ) {
     Scaffold(
         modifier = modifier,
@@ -120,5 +120,8 @@ private fun UserDefinedRoomNotificationSettingsTopBar(
 internal fun UserDefinedRoomNotificationSettingsPreview(
     @PreviewParameter(UserDefinedRoomNotificationSettingsStateProvider::class) state: RoomNotificationSettingsState
 ) = ElementPreview {
-    UserDefinedRoomNotificationSettingsView(state)
+    UserDefinedRoomNotificationSettingsView(
+        state = state,
+        onBackPressed = {},
+    )
 }