diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt index b9b9e7e4a7..b8997865ce 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt @@ -292,7 +292,7 @@ private fun AttachmentStateView( is AttachmentsState.Sending.Processing -> ProgressDialogType.Indeterminate }, text = stringResource(id = CommonStrings.common_sending), - isCancellable = true, + showCancelButton = true, onDismissRequest = onCancel, ) } diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewView.kt index dc13758bd1..aaacdbac2d 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/attachments/preview/AttachmentsPreviewView.kt @@ -98,7 +98,7 @@ private fun AttachmentSendStateView( SendActionState.Sending.Processing -> ProgressDialogType.Indeterminate }, text = stringResource(id = CommonStrings.common_sending), - isCancellable = true, + showCancelButton = true, onDismissRequest = onDismissClick, ) } diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/focus/FocusRequestStateView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/focus/FocusRequestStateView.kt index 4a4381d269..3c2892784d 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/focus/FocusRequestStateView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/focus/FocusRequestStateView.kt @@ -20,6 +20,7 @@ import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.res.stringResource import androidx.compose.ui.tooling.preview.PreviewParameter +import androidx.compose.ui.window.DialogProperties import io.element.android.features.messages.impl.timeline.FocusRequestState import io.element.android.libraries.designsystem.components.ProgressDialog import io.element.android.libraries.designsystem.components.dialogs.ErrorDialog @@ -49,7 +50,11 @@ fun FocusRequestStateView( ) } FocusRequestState.Fetching -> { - ProgressDialog(modifier = modifier, onDismissRequest = onClearFocusRequestState) + ProgressDialog( + modifier = modifier, + properties = DialogProperties(dismissOnBackPress = true, dismissOnClickOutside = true), + onDismissRequest = onClearFocusRequestState, + ) } else -> Unit } diff --git a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/ProgressDialog.kt b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/ProgressDialog.kt index e1872b0a98..b1defd99d8 100644 --- a/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/ProgressDialog.kt +++ b/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/components/ProgressDialog.kt @@ -51,7 +51,8 @@ fun ProgressDialog( modifier: Modifier = Modifier, text: String? = null, type: ProgressDialogType = ProgressDialogType.Indeterminate, - isCancellable: Boolean = false, + properties: DialogProperties = DialogProperties(dismissOnBackPress = false, dismissOnClickOutside = false), + showCancelButton: Boolean = false, onDismissRequest: () -> Unit = {}, ) { DisposableEffect(Unit) { @@ -61,12 +62,12 @@ fun ProgressDialog( } Dialog( onDismissRequest = onDismissRequest, - properties = DialogProperties(dismissOnBackPress = false, dismissOnClickOutside = false) + properties = properties, ) { ProgressDialogContent( modifier = modifier, text = text, - isCancellable = isCancellable, + isCancellable = showCancelButton, onCancelClick = onDismissRequest, progressIndicator = { when (type) { @@ -152,5 +153,5 @@ internal fun ProgressDialogContentPreview() = ElementThemedPreview { @PreviewsDayNight @Composable internal fun ProgressDialogPreview() = ElementPreview { - ProgressDialog(text = "test dialog content", isCancellable = true) + ProgressDialog(text = "test dialog content", showCancelButton = true) }