From 4e06ccd610e26ddef92a37d886975d9a65c64010 Mon Sep 17 00:00:00 2001
From: ganfra <francoisg@matrix.org>
Date: Fri, 5 Jan 2024 13:53:02 +0100
Subject: [PATCH] RoomInviteMembers : add small tests

---
 .../invite/RoomInviteMembersStateProvider.kt  | 11 +++++++++
 .../invite/RoomInviteMembersPresenterTest.kt  | 23 +++++++++++--------
 2 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersStateProvider.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersStateProvider.kt
index c9ae8a606a..e7b0ba3397 100644
--- a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersStateProvider.kt
+++ b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersStateProvider.kt
@@ -64,6 +64,17 @@ internal class RoomInviteMembersStateProvider : PreviewParameterProvider<RoomInv
                     )
                 )
             ),
+            aRoomInviteMembersState(
+                isSearchActive = true,
+                canInvite = true,
+                searchQuery = "@alice:server.org",
+                searchResults = SearchBarResultState.Results(
+                    persistentListOf(
+                        InvitableUser(aMatrixUser("@alice:server.org"), isUnresolved = true),
+                    )
+                ),
+                isFetchingSearchResults = true,
+            ),
         )
 }
 
diff --git a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersPresenterTest.kt b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersPresenterTest.kt
index 3c801d9581..f2a875b956 100644
--- a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersPresenterTest.kt
+++ b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/impl/invite/RoomInviteMembersPresenterTest.kt
@@ -38,6 +38,8 @@ import io.element.android.libraries.usersearch.api.UserSearchResult
 import io.element.android.libraries.usersearch.api.UserSearchResults
 import io.element.android.libraries.usersearch.test.FakeUserRepository
 import io.element.android.tests.testutils.WarmUpRule
+import io.element.android.tests.testutils.awaitLastSequentialItem
+import io.element.android.tests.testutils.consumeItemsUntilPredicate
 import io.element.android.tests.testutils.testCoroutineDispatchers
 import kotlinx.collections.immutable.ImmutableList
 import kotlinx.collections.immutable.persistentListOf
@@ -95,7 +97,7 @@ internal class RoomInviteMembersPresenterTest {
     }
 
     @Test
-    fun `present - performs search and handles no results`() = runTest {
+    fun `present - performs search and handles empty result list`() = runTest {
         val repository = FakeUserRepository()
         val presenter = RoomInviteMembersPresenter(
             userRepository = repository,
@@ -106,17 +108,18 @@ internal class RoomInviteMembersPresenterTest {
             presenter.present()
         }.test {
             val initialState = awaitItem()
-            skipItems(1)
-
             initialState.eventSink(RoomInviteMembersEvents.UpdateSearchQuery("some query"))
-            skipItems(1)
-
             assertThat(repository.providedQuery).isEqualTo("some query")
-            repository.emitResult(UserSearchResults(results = emptyList()))
-            skipItems(1)
-
-            val resultState = awaitItem()
-            assertThat(resultState.searchResults).isInstanceOf(SearchBarResultState.NoResultsFound::class.java)
+            repository.emitResult(UserSearchResults(results = emptyList(), isFetchingSearchResults = true))
+            consumeItemsUntilPredicate { it.isFetchingSearchResults }.last().also { state ->
+                assertThat(state.searchResults).isInstanceOf(SearchBarResultState.Empty::class.java)
+                assertThat(state.isFetchingSearchResults).isTrue()
+            }
+            repository.emitResult(UserSearchResults(results = emptyList(), isFetchingSearchResults = false))
+            consumeItemsUntilPredicate { !it.isFetchingSearchResults }.last().also { state ->
+                assertThat(state.searchResults).isInstanceOf(SearchBarResultState.NoResultsFound::class.java)
+                assertThat(state.isFetchingSearchResults).isFalse()
+            }
         }
     }