diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemAspectRatioBox.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemAspectRatioBox.kt index 7b2e2099d4..48072ce5bf 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemAspectRatioBox.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemAspectRatioBox.kt @@ -18,7 +18,7 @@ import androidx.compose.ui.unit.dp const val MIN_HEIGHT_IN_DP = 100 const val MAX_HEIGHT_IN_DP = 360 -private const val DEFAULT_ASPECT_RATIO = 1.33f +const val DEFAULT_ASPECT_RATIO = 1.33f @Composable fun TimelineItemAspectRatioBox( diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemImageView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemImageView.kt index b876fc3a3f..af401dc56a 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemImageView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemImageView.kt @@ -100,9 +100,10 @@ fun TimelineItemImageView( LocalContentColor provides ElementTheme.colors.textPrimary, LocalTextStyle provides ElementTheme.typography.fontBodyLgRegular ) { + val aspectRatio = content.aspectRatio ?: DEFAULT_ASPECT_RATIO EditorStyledText( modifier = Modifier - .widthIn(min = MIN_HEIGHT_IN_DP.dp * content.aspectRatio!!, max = MAX_HEIGHT_IN_DP.dp * content.aspectRatio), + .widthIn(min = MIN_HEIGHT_IN_DP.dp * aspectRatio, max = MAX_HEIGHT_IN_DP.dp * aspectRatio), text = caption, style = ElementRichTextEditorStyle.textStyle(), releaseOnDetach = false, @@ -136,5 +137,16 @@ internal fun TimelineImageWithCaptionRowPreview() = ElementPreview { ), ) } + ATimelineItemEventRow( + event = aTimelineItemEvent( + isMine = false, + content = aTimelineItemImageContent().copy( + filename = "image.jpg", + body = "Image with null aspectRatio", + aspectRatio = null, + ), + groupPosition = TimelineItemGroupPosition.Last, + ), + ) } } diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemStickerView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemStickerView.kt index 684e3ea54a..f895eddc85 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemStickerView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemStickerView.kt @@ -23,18 +23,17 @@ import io.element.android.libraries.designsystem.preview.PreviewsDayNight import io.element.android.libraries.matrix.ui.media.MediaRequestData private const val STICKER_SIZE_IN_DP = 128 -private const val DEFAULT_ASPECT_RATIO = 1.33f @Composable fun TimelineItemStickerView( content: TimelineItemStickerContent, modifier: Modifier = Modifier, ) { - val safeAspectRatio = content.aspectRatio ?: DEFAULT_ASPECT_RATIO + val aspectRatio = content.aspectRatio ?: DEFAULT_ASPECT_RATIO Box( modifier = modifier .heightIn(min = STICKER_SIZE_IN_DP.dp, max = STICKER_SIZE_IN_DP.dp) - .aspectRatio(safeAspectRatio, false), + .aspectRatio(aspectRatio, false), contentAlignment = Alignment.TopStart, ) { BlurHashAsyncImage( diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt index a571403e40..31cb5f1607 100644 --- a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt +++ b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt @@ -72,7 +72,9 @@ fun TimelineItemVideoView( modifier = modifier.semantics { contentDescription = description } ) { val containerModifier = if (content.showCaption) { - Modifier.padding(top = 6.dp).clip(RoundedCornerShape(6.dp)) + Modifier + .padding(top = 6.dp) + .clip(RoundedCornerShape(6.dp)) } else { Modifier } @@ -116,9 +118,10 @@ fun TimelineItemVideoView( LocalContentColor provides ElementTheme.colors.textPrimary, LocalTextStyle provides ElementTheme.typography.fontBodyLgRegular, ) { + val aspectRatio = content.aspectRatio ?: DEFAULT_ASPECT_RATIO EditorStyledText( modifier = Modifier - .widthIn(min = MIN_HEIGHT_IN_DP.dp * content.aspectRatio!!, max = MAX_HEIGHT_IN_DP.dp * content.aspectRatio), + .widthIn(min = MIN_HEIGHT_IN_DP.dp * aspectRatio, max = MAX_HEIGHT_IN_DP.dp * aspectRatio), text = caption, style = ElementRichTextEditorStyle.textStyle(), releaseOnDetach = false, @@ -152,5 +155,16 @@ internal fun TimelineVideoWithCaptionRowPreview() = ElementPreview { ), ) } + ATimelineItemEventRow( + event = aTimelineItemEvent( + isMine = false, + content = aTimelineItemVideoContent().copy( + filename = "video.mp4", + body = "Video with null aspect ratio", + aspectRatio = null, + ), + groupPosition = TimelineItemGroupPosition.Last, + ), + ) } }