letro/letro-android
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

feat(room preview) : use room summary joined members count

Browse Source
This commit is contained in:
ganfra
2025-02-07 21:06:52 +01:00
committed by Jorge Martin Espinosa
parent ba07370dfa
commit 3b0ac5420a
3 changed files with 48 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
features/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenter.kt
View File

@@ -256,7 +256,7 @@ internal fun MatrixRoomInfo.toContentState(): ContentState {
name = name,
topic = topic,
alias = canonicalAlias,
numberOfMembers = activeMembersCount,
numberOfMembers = joinedMembersCount,
isDm = isDm,
roomType = if (isSpace) RoomType.Space else RoomType.Room,
roomAvatarUrl = avatarUrl,

50
features/joinroom/impl/src/test/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenterTest.kt
View File

@@ -91,7 +91,7 @@ class JoinRoomPresenterTest {
assertThat(contentState.name).isEqualTo(roomSummary.info.name)
assertThat(contentState.topic).isEqualTo(roomSummary.info.topic)
assertThat(contentState.alias).isEqualTo(roomSummary.info.canonicalAlias)
assertThat(contentState.numberOfMembers).isEqualTo(roomSummary.info.activeMembersCount)
assertThat(contentState.numberOfMembers).isEqualTo(roomSummary.info.joinedMembersCount)
assertThat(contentState.isDm).isEqualTo(roomSummary.info.isDirect)
assertThat(contentState.roomAvatarUrl).isEqualTo(roomSummary.info.avatarUrl)
}
@@ -545,7 +545,7 @@ class JoinRoomPresenterTest {
}
@Test
fun `present - when room is not known RoomPreview is loaded as Private `() = runTest {
fun `present - when room is not known RoomPreview is loaded as Private`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(
@@ -565,7 +565,47 @@ class JoinRoomPresenterTest {
}
@Test
fun `present - when room is not known RoomPreview is loaded as KnockRestricted `() = runTest {
fun `present - when room is not known RoomPreview is loaded as Custom`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(
aRoomPreviewInfo(joinRule = JoinRule.Custom("custom"))
)
}
)
val presenter = createJoinRoomPresenter(
matrixClient = client
)
presenter.test {
skipItems(1)
awaitItem().also { state ->
assertThat(state.joinAuthorisationStatus).isEqualTo(JoinAuthorisationStatus.Unknown)
}
}
}
@Test
fun `present - when room is not known RoomPreview is loaded as Invite`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(
aRoomPreviewInfo(joinRule = JoinRule.Invite)
)
}
)
val presenter = createJoinRoomPresenter(
matrixClient = client
)
presenter.test {
skipItems(1)
awaitItem().also { state ->
assertThat(state.joinAuthorisationStatus).isEqualTo(JoinAuthorisationStatus.NeedInvite)
}
}
}
@Test
fun `present - when room is not known RoomPreview is loaded as KnockRestricted`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(
@@ -585,7 +625,7 @@ class JoinRoomPresenterTest {
}
@Test
fun `present - when room is not known RoomPreview is loaded as Restricted `() = runTest {
fun `present - when room is not known RoomPreview is loaded as Restricted`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(
@@ -605,7 +645,7 @@ class JoinRoomPresenterTest {
}
@Test
fun `present - when room is not known RoomPreview is loaded as Space `() = runTest {
fun `present - when room is not known RoomPreview is loaded as Space`() = runTest {
val client = FakeMatrixClient(
getRoomPreviewInfoResult = { _, _ ->
Result.success(