From 27608eca644e8c144000c4ec03150e1e8de276af Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Thu, 8 Dec 2022 17:26:47 +0100
Subject: [PATCH] [lint] Import lint.xml from Element Android

---
 app/build.gradle.kts |   6 +++
 tools/lint/lint.xml  | 117 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 123 insertions(+)
 create mode 100644 tools/lint/lint.xml

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index b336054c10..ab62144c68 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -108,6 +108,12 @@ android {
             kotlin.srcDir("build/generated/ksp/test/kotlin")
         }
     }
+
+    lint {
+        lintConfig = file("../tools/lint/lint.xml")
+        checkDependencies = true
+        abortOnError = true
+    }
 }
 
 dependencies {
diff --git a/tools/lint/lint.xml b/tools/lint/lint.xml
new file mode 100644
index 0000000000..3d3b073749
--- /dev/null
+++ b/tools/lint/lint.xml
@@ -0,0 +1,117 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+
+    <!-- Ensure this file does not contain unknown Ids -->
+    <issue id="UnknownIssueId" severity="error" />
+
+    <!-- Modify some severity -->
+
+    <!-- Resource -->
+    <issue id="MissingTranslation" severity="ignore" />
+    <issue id="TypographyEllipsis" severity="error" />
+    <issue id="ImpliedQuantity" severity="warning" />
+    <issue id="MissingQuantity" severity="warning" />
+    <issue id="UnusedQuantity" severity="error" />
+    <issue id="IconXmlAndPng" severity="error" />
+    <issue id="IconDipSize" severity="error" />
+    <issue id="IconDuplicatesConfig" severity="error" />
+    <issue id="IconDuplicates" severity="error" />
+    <issue id="IconExpectedSize" severity="error" />
+    <issue id="LocaleFolder" severity="error" />
+
+    <!-- AlwaysShowAction is considered as an error to force ignoring the issue when detected -->
+    <issue id="AlwaysShowAction" severity="error" />
+
+    <issue id="TooManyViews" severity="warning">
+        <!-- Ignore TooManyViews in debug build type -->
+        <ignore path="**/src/debug/**" />
+    </issue>
+
+    <issue id="UnusedResources" severity="error">
+        <!-- Ignore unused resource in debug build type -->
+        <ignore path="**/src/debug/**" />
+
+        <!-- Following resources are for F-Droid variant only, so ignore for GPlay -->
+        <ignore regexp="settings_troubleshoot_test_service_boot_*" />
+        <ignore regexp="settings_troubleshoot_test_bg_restricted_*" />
+        <ignore regexp="settings_troubleshoot_test_battery_*" />
+
+        <!-- Following resources are for GPlay variant only, so ignore for F-Droid -->
+        <ignore regexp="settings_troubleshoot_test_play_services_" />
+        <ignore regexp="settings_troubleshoot_test_push_loop_" />
+        <ignore regexp="settings_troubleshoot_test_token_registration_" />
+        <ignore regexp="settings_troubleshoot_test_fcm_" />
+        <ignore regexp="no_valid_google_play_services_apk" />
+        <ignore regexp="sas_error_unknown" />
+    </issue>
+
+    <!-- UX -->
+    <issue id="ButtonOrder" severity="error" />
+    <issue id="TextFields" severity="error" />
+
+    <!-- Accessibility -->
+    <issue id="LabelFor" severity="error" />
+    <issue id="ContentDescription" severity="error" />
+    <issue id="SpUsage" severity="error" />
+
+    <!-- Layout -->
+    <issue id="UnknownIdInLayout" severity="error" />
+    <issue id="StringFormatCount" severity="error" />
+    <issue id="HardcodedText" severity="error" />
+    <issue id="ObsoleteLayoutParam" severity="error" />
+    <issue id="InefficientWeight" severity="error" />
+    <issue id="DisableBaselineAlignment" severity="error" />
+    <issue id="ScrollViewSize" severity="error" />
+    <issue id="NegativeMargin" severity="error" />
+    <issue id="UseCompatTextViewDrawableXml" severity="error" />
+
+    <!-- RTL -->
+    <issue id="RtlEnabled" severity="error" />
+    <issue id="RtlHardcoded" severity="error" />
+    <issue id="RtlSymmetry" severity="error" />
+
+    <!-- Code -->
+    <issue id="NewApi" severity="error" />
+    <issue id="SetTextI18n" severity="error" />
+    <issue id="ViewConstructor" severity="error" />
+    <issue id="UseValueOf" severity="error" />
+    <issue id="ObsoleteSdkInt" severity="error" />
+    <issue id="Recycle" severity="error" />
+    <issue id="KotlinPropertyAccess" severity="error" />
+    <issue id="DefaultLocale" severity="error" />
+    <issue id="CheckResult" severity="error" />
+    <issue id="StaticFieldLeak" severity="error" />
+
+    <issue id="InvalidPackage">
+        <!-- Ignore error from HtmlCompressor lib -->
+        <ignore path="**/htmlcompressor-1.4.jar" />
+        <!-- Ignore error from dropbox-core-sdk-3.0.8 lib, which comes with Jitsi library -->
+        <ignore path="**/dropbox-core-sdk-3.0.8.jar" />
+    </issue>
+
+    <!-- Manifest -->
+    <issue id="PermissionImpliesUnsupportedChromeOsHardware" severity="error" />
+    <issue id="DataExtractionRules" severity="error" />
+
+    <!-- Performance -->
+    <issue id="UselessParent" severity="error" />
+
+    <!-- Dependencies -->
+    <issue id="KtxExtensionAvailable" severity="error" />
+
+    <!-- Timber -->
+    <!--    This rule is failing on CI because it's marked as unknwown rule id :/-->
+    <!--    <issue id="BinaryOperationInTimber" severity="error" />-->
+    <issue id="LogNotTimber" severity="error" />
+
+    <!-- Wording -->
+    <issue id="Typos" severity="error" />
+    <issue id="TypographyDashes" severity="error" />
+    <issue id="PluralsCandidate" severity="error" />
+
+    <!-- Notification -->
+    <issue id="LaunchActivityFromNotification" severity="error" />
+
+    <!-- DI -->
+    <issue id="JvmStaticProvidesInObjectDetector" severity="error" />
+</lint>