From 1a216d5a5729bb345f88e1015a80c438ddcf28b0 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Tue, 27 Jun 2023 09:55:14 +0200 Subject: [PATCH] Update check rule. --- tools/check/forbidden_strings_in_code.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/check/forbidden_strings_in_code.txt b/tools/check/forbidden_strings_in_code.txt index 41a6c16466..6c91c0baf7 100755 --- a/tools/check/forbidden_strings_in_code.txt +++ b/tools/check/forbidden_strings_in_code.txt @@ -130,5 +130,5 @@ System\.currentTimeMillis\(\)===1 ### Suspicious String template. Please check that the string template will behave as expected, i.e. the class field and not the whole object will be used. For instance `Timber.d("$event.type")` is not correct, you should write `Timber.d("${event.type}")`. In the former the whole event content will be logged, since it's a data class. If this is expected (i.e. to fix false positive), please add explicit curly braces (`{` and `}`) around the variable, for instance `"elementLogs.${i}.txt"` \$[a-zA-Z_]\w*\??\.[a-zA-Z_] -### Use `import io.element.android.libraries.ui.strings.R as StringsR` then `StringR.string.` instead -io\.element\.android\.libraries\.ui\.strings\.R\. +### Use `import io.element.android.libraries.ui.strings.CommonStrings` then `CommonStrings.` instead +import io\.element\.android\.libraries\.ui\.strings\.R