From 174d45f4dd0033ac9581e5d7231eefd05c1da023 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 3 Jun 2024 18:24:03 +0200 Subject: [PATCH] Rename parameter `roomId` to `dmRoomId` for clarity. --- .../android/features/roomdetails/impl/RoomDetailsFlowNode.kt | 4 ++-- .../android/features/userprofile/impl/UserProfileFlowNode.kt | 4 ++-- .../features/userprofile/shared/UserProfileNodeHelper.kt | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsFlowNode.kt b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsFlowNode.kt index 3c9d3d0e37..9b3cb0f8bc 100644 --- a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsFlowNode.kt +++ b/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsFlowNode.kt @@ -194,8 +194,8 @@ class RoomDetailsFlowNode @AssistedInject constructor( plugins().forEach { it.onOpenRoom(roomId) } } - override fun onStartCall(roomId: RoomId) { - ElementCallActivity.start(context, CallType.RoomCall(roomId = roomId, sessionId = room.sessionId)) + override fun onStartCall(dmRoomId: RoomId) { + ElementCallActivity.start(context, CallType.RoomCall(sessionId = room.sessionId, roomId = dmRoomId)) } } val plugins = listOf(RoomMemberDetailsNode.RoomMemberDetailsInput(navTarget.roomMemberId), callback) diff --git a/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/UserProfileFlowNode.kt b/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/UserProfileFlowNode.kt index 402e07dbba..9101254126 100644 --- a/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/UserProfileFlowNode.kt +++ b/features/userprofile/impl/src/main/kotlin/io/element/android/features/userprofile/impl/UserProfileFlowNode.kt @@ -83,8 +83,8 @@ class UserProfileFlowNode @AssistedInject constructor( plugins().forEach { it.onOpenRoom(roomId) } } - override fun onStartCall(roomId: RoomId) { - ElementCallActivity.start(context, CallType.RoomCall(sessionId = sessionIdHolder.current, roomId = roomId)) + override fun onStartCall(dmRoomId: RoomId) { + ElementCallActivity.start(context, CallType.RoomCall(sessionId = sessionIdHolder.current, roomId = dmRoomId)) } } val params = UserProfileNode.UserProfileInputs(userId = inputs().userId) diff --git a/features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileNodeHelper.kt b/features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileNodeHelper.kt index 7a669772f7..027f789515 100644 --- a/features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileNodeHelper.kt +++ b/features/userprofile/shared/src/main/kotlin/io/element/android/features/userprofile/shared/UserProfileNodeHelper.kt @@ -32,7 +32,7 @@ class UserProfileNodeHelper( interface Callback : NodeInputs { fun openAvatarPreview(username: String, avatarUrl: String) fun onStartDM(roomId: RoomId) - fun onStartCall(roomId: RoomId) + fun onStartCall(dmRoomId: RoomId) } fun onShareUser(