From 1600d68f4bcb0092d13494d21cc13ddc4e03c777 Mon Sep 17 00:00:00 2001 From: ganfra Date: Tue, 10 Feb 2026 21:06:36 +0100 Subject: [PATCH] Fix tests after ff enabled --- .../features/createroom/impl/ConfigureRoomPresenterTest.kt | 6 +++++- .../impl/root/SecurityAndPrivacyPresenterTest.kt | 5 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/ConfigureRoomPresenterTest.kt b/features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/ConfigureRoomPresenterTest.kt index 1016fea46c..fcedcb2367 100644 --- a/features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/ConfigureRoomPresenterTest.kt +++ b/features/createroom/impl/src/test/kotlin/io/element/android/features/createroom/impl/ConfigureRoomPresenterTest.kt @@ -219,6 +219,7 @@ class ConfigureRoomPresenterTest { fun `present - when creating a room in a space if the room doesn't receive the power levels value it can't be added to the space`() = runTest { val addChildToSpaceResult = lambdaRecorder> { _, _ -> Result.success(Unit) } val spaceService = FakeSpaceService( + editableSpacesResult = { Result.success(emptyList()) }, addChildToSpaceResult = addChildToSpaceResult, ) val roomInfoFlow = MutableStateFlow>(Optional.empty()) @@ -261,6 +262,7 @@ class ConfigureRoomPresenterTest { fun `present - creating a room and adding it into a parent space works when all the data is available`() = runTest { val addChildToSpaceResult = lambdaRecorder> { _, _ -> Result.success(Unit) } val spaceService = FakeSpaceService( + editableSpacesResult = { Result.success(emptyList()) }, addChildToSpaceResult = addChildToSpaceResult, ) val roomInfoFlow = MutableStateFlow>(Optional.empty()) @@ -522,7 +524,9 @@ class ConfigureRoomPresenterTest { private fun createMatrixClient( isAliasAvailable: Boolean = true, - spaceService: FakeSpaceService = FakeSpaceService(), + spaceService: FakeSpaceService = FakeSpaceService( + editableSpacesResult = { Result.success(emptyList()) } + ), ) = FakeMatrixClient( userIdServerNameLambda = { "matrix.org" }, resolveRoomAliasResult = { diff --git a/features/securityandprivacy/impl/src/test/kotlin/io/element/android/features/securityandprivacy/impl/root/SecurityAndPrivacyPresenterTest.kt b/features/securityandprivacy/impl/src/test/kotlin/io/element/android/features/securityandprivacy/impl/root/SecurityAndPrivacyPresenterTest.kt index f431a2c761..d2844c79f0 100644 --- a/features/securityandprivacy/impl/src/test/kotlin/io/element/android/features/securityandprivacy/impl/root/SecurityAndPrivacyPresenterTest.kt +++ b/features/securityandprivacy/impl/src/test/kotlin/io/element/android/features/securityandprivacy/impl/root/SecurityAndPrivacyPresenterTest.kt @@ -809,14 +809,13 @@ class SecurityAndPrivacyPresenterTest { ) ) ) - // No spaces available, so isSpaceMemberSelectable should be false + // Room has SpaceMember access with existing space ID, so isSpaceMemberSelectable is true val presenter = createSecurityAndPrivacyPresenter(room = room) presenter.test { skipItems(1) with(awaitItem()) { assertThat(savedSettings.roomAccess).isInstanceOf(SecurityAndPrivacyRoomAccess.SpaceMember::class.java) - assertThat(isSpaceMemberSelectable).isFalse() - // showSpaceMemberOption should still be true because savedSettings has SpaceMember + assertThat(isSpaceMemberSelectable).isTrue() assertThat(showSpaceMemberOption).isTrue() } cancelAndIgnoreRemainingEvents()