From 0f71b3eb6428e207c4d5231dbec4cef62fe119f4 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoit@matrix.org>
Date: Wed, 29 May 2024 15:14:38 +0200
Subject: [PATCH] Add a Konsist test to check function parameter name, and fix
 existing issue.

---
 .../poll/impl/create/CreatePollView.kt        |  6 ++--
 .../tests/konsist/KonsistParameterNameTest.kt | 34 +++++++++++++++++++
 2 files changed, 37 insertions(+), 3 deletions(-)
 create mode 100644 tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistParameterNameTest.kt

diff --git a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/create/CreatePollView.kt b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/create/CreatePollView.kt
index 41f704e006..81c9b7220e 100644
--- a/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/create/CreatePollView.kt
+++ b/features/poll/impl/src/main/kotlin/io/element/android/features/poll/impl/create/CreatePollView.kt
@@ -102,7 +102,7 @@ fun CreatePollView(
             CreatePollTopAppBar(
                 mode = state.mode,
                 saveEnabled = state.canSave,
-                onBackPress = navBack,
+                onBackClick = navBack,
                 onSaveClick = { state.eventSink(CreatePollEvents.Save) }
             )
         },
@@ -219,7 +219,7 @@ fun CreatePollView(
 private fun CreatePollTopAppBar(
     mode: CreatePollState.Mode,
     saveEnabled: Boolean,
-    onBackPress: () -> Unit = {},
+    onBackClick: () -> Unit = {},
     onSaveClick: () -> Unit = {},
 ) {
     TopAppBar(
@@ -233,7 +233,7 @@ private fun CreatePollTopAppBar(
             )
         },
         navigationIcon = {
-            BackButton(onClick = onBackPress)
+            BackButton(onClick = onBackClick)
         },
         actions = {
             TextButton(
diff --git a/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistParameterNameTest.kt b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistParameterNameTest.kt
new file mode 100644
index 0000000000..1f883e5ea8
--- /dev/null
+++ b/tests/konsist/src/test/kotlin/io/element/android/tests/konsist/KonsistParameterNameTest.kt
@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2024 New Vector Ltd
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.element.android.tests.konsist
+
+import com.lemonappdev.konsist.api.Konsist
+import com.lemonappdev.konsist.api.ext.list.withParameter
+import com.lemonappdev.konsist.api.verify.assertEmpty
+import org.junit.Test
+
+class KonsistParameterNameTest {
+    @Test
+    fun `Function parameter should not end with 'Press' but with 'Click'`() {
+        Konsist.scopeFromProject()
+            .functions()
+            .withParameter { parameter ->
+                parameter.name.endsWith("Press")
+            }
+            .assertEmpty(additionalMessage = "Please rename the parameter, for instance from 'onBackPress' to 'onBackClick'.")
+    }
+}