From 003af22c3170a60b70785c28ceccf50901bafa92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jorge=20Mart=C3=ADn?= Date: Tue, 28 Oct 2025 17:12:40 +0100 Subject: [PATCH] Fix api breaks: - `ComposerDraft` now takes a list of media attachments. - `HumanQrLoginException` has a couple of new cases. - `Client.loginWithQrCode` now returns a `LoginWithQrCodeHandle`, which we need to call using `scan` to have the same behaviour as before. --- .../matrix/api/auth/qrlogin/QrLoginException.kt | 2 ++ .../impl/auth/RustMatrixAuthenticationService.kt | 9 ++++++--- .../matrix/impl/auth/qrlogin/QrErrorMapper.kt | 2 ++ .../matrix/impl/room/draft/ComposerDraftMapper.kt | 4 +++- settings.gradle.kts | 13 +++++++------ 5 files changed, 20 insertions(+), 10 deletions(-) diff --git a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/auth/qrlogin/QrLoginException.kt b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/auth/qrlogin/QrLoginException.kt index ab278abd56..6a2871dc56 100644 --- a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/auth/qrlogin/QrLoginException.kt +++ b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/auth/qrlogin/QrLoginException.kt @@ -17,4 +17,6 @@ sealed class QrLoginException : Exception() { data object SlidingSyncNotAvailable : QrLoginException() data object OtherDeviceNotSignedIn : QrLoginException() data object Unknown : QrLoginException() + data object CheckCodeAlreadySent : QrLoginException() + data object CheckCodeCannotBeSent : QrLoginException() } diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt index 6342721593..408af2eb0a 100644 --- a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt +++ b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/RustMatrixAuthenticationService.kt @@ -289,10 +289,13 @@ class RustMatrixAuthenticationService( qrCodeData = sdkQrCodeLoginData, ) client.loginWithQrCode( - qrCodeData = qrCodeData.rustQrCodeData, oidcConfiguration = oidcConfiguration, - progressListener = progressListener, - ) + ).use { + it.scan( + qrCodeData = qrCodeData.rustQrCodeData, + progressListener = progressListener, + ) + } // Ensure that the user is not already logged in with the same account ensureNotAlreadyLoggedIn(client) val sessionData = client.session() diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/qrlogin/QrErrorMapper.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/qrlogin/QrErrorMapper.kt index 7b1c614bec..9b7a19aea4 100644 --- a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/qrlogin/QrErrorMapper.kt +++ b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/auth/qrlogin/QrErrorMapper.kt @@ -42,5 +42,7 @@ object QrErrorMapper { is RustHumanQrLoginException.Unknown -> QrLoginException.Unknown is RustHumanQrLoginException.OidcMetadataInvalid -> QrLoginException.OidcMetadataInvalid is RustHumanQrLoginException.SlidingSyncNotAvailable -> QrLoginException.SlidingSyncNotAvailable + is RustHumanQrLoginException.CheckCodeAlreadySent -> QrLoginException.CheckCodeAlreadySent + is RustHumanQrLoginException.CheckCodeCannotBeSent -> QrLoginException.CheckCodeCannotBeSent } } diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/draft/ComposerDraftMapper.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/draft/ComposerDraftMapper.kt index 1bdadb96fc..d4435b24a1 100644 --- a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/draft/ComposerDraftMapper.kt +++ b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/draft/ComposerDraftMapper.kt @@ -17,7 +17,9 @@ internal fun ComposerDraft.into(): RustComposerDraft { return RustComposerDraft( plainText = plainText, htmlText = htmlText, - draftType = draftType.into() + draftType = draftType.into(), + // TODO add media attachments to the draft + attachments = emptyList(), ) } diff --git a/settings.gradle.kts b/settings.gradle.kts index 9245034508..16f24f3a10 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -5,11 +5,9 @@ * Please see LICENSE files in the repository root for full details. */ -import java.net.URI - pluginManagement { repositories { - includeBuild("plugins") + includeBuild("plugins") gradlePluginPortal() google() mavenCentral() @@ -18,14 +16,17 @@ pluginManagement { dependencyResolutionManagement { repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) repositories { - google() - mavenCentral() maven { - url = URI("https://www.jitpack.io") + url = uri("https://www.jitpack.io") content { includeModule("com.github.matrix-org", "matrix-analytics-events") } } + google() + mavenCentral() + maven { + url = uri("https://repo1.maven.org/maven2/") + } flatDir { dirs("libraries/matrix/libs") }